MAAS

[edge] Links to specific machines are broken

Bug #1939033 reported by Stéphane Graber
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
High
Caleb Ellis
MAAS 3.1.0
maas-ui
Fix Released
Unknown

Bug Description

This is on current latest/edge.

When on the machine list, clicking a specific machine works as expected and gets me to something like https://services.stgraber.org/MAAS/r/machine/7w3f7e/summary. But if I middle click to open in a tab, I instead get sent to https://services.stgraber.org/MAAS/r/machine/7w3f7e which apparently isn't a valid URL and so get redirected to https://services.stgraber.org/MAAS/r/dashboard

This is extremely annoying as my normal workflow is to open the MAAS machine list and then open all the machines I care about in tabs. Doing this now, just results in every one of my tabs showing me a device discovery list (/r/dashboard) instead of the machine I want to look at.

Tags: ui
Adam Collard (adam-collard)
tags: added: ui
Revision history for this message
Bill Wear (billwear) wrote :

i can't reproduce this in the edge distribution, in Firefox or Chrome. can you give me more information about what you're using, and possibly some http logs?

Changed in maas:
status: New → Incomplete
Revision history for this message
Stéphane Graber (stgraber) wrote :

This one may also be RBAC related.
I'm hitting the issue in Firefox, other team members reported the same behavior on their end.

The HTTP log isn't very interesting as the bulk of this appears to be going on within javascript instead:
2021-08-10 17:01:14 regiond: [info] 2602:fd23:8:1000:216:3eff:fe82:caa8 GET /MAAS/ HTTP/1.1 --> 302 FOUND (referrer: -; agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:90.0) Gecko/20100101 Firefox/90.0)
2021-08-10 17:01:15 regiond: [info] 2602:fd23:8:1000:216:3eff:fe82:caa8 GET /MAAS/r/ HTTP/1.1 --> 200 OK (referrer: -; agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:90.0) Gecko/20100101 Firefox/90.0)
2021-08-10 17:01:15 regiond: [info] 2602:fd23:8:1000:216:3eff:fe82:caa8 GET /MAAS/accounts/login/ HTTP/1.1 --> 200 OK (referrer: https://services.stgraber.org/MAAS/r/; agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:90.0) Gecko/20100101 Firefox/90.0)

Changed in maas:
status: Incomplete → New
Revision history for this message
Caleb Ellis (caleb-ellis) wrote :

It looks like this has been inadvertently fixed as of this commit:
https://git.launchpad.net/maas/commit/?id=4b8977764d95f286867a7539aeb1ac437da5169a

A separate bug regarding setting cookies was fixed, specifically the line referenced here: https://github.com/canonical-web-and-design/maas-ui/pull/2944/files#diff-d89226ec31d158da289f4b79e877ca3b12b70d993555b6bf4fec186446181e61R99

At least in my own testing, the issue is present before that commit and not present after that commit, so I will assume that nothing more needs to be done. Please re-open if you're still running into this issue on the edge snap. Thanks!

Revision history for this message
Caleb Ellis (caleb-ellis) wrote :

For context the issue seems like it was a race condition where it was assumed a user would always be loaded before something else, but in the case of MAASes with RBAC authentication this was not the case.

Changed in maas:
status: New → Fix Committed
importance: Undecided → High
assignee: nobody → Caleb Ellis (caleb-ellis)
milestone: none → 3.0.1
milestone: 3.0.1 → none
Bug Watch Updater (bug-watch-updater)
Changed in maas-ui:
importance: Undecided → Unknown
status: New → Fix Released
Adam Collard (adam-collard)
Changed in maas:
milestone: none → 3.1.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.