Enable fib-onlink-tests.sh and msg_zerocopy.sh in kselftests/net on Bionic
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-kernel-tests |
Fix Released
|
Undecided
|
Po-Hsu Lin | ||
linux (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Po-Hsu Lin |
Bug Description
[Impact]
Found this issue while debugging missing tests with bug 1934282.
On Bionic there are 3 scripts that are not in the Makefile of the kselftests/net:
$ for file in $(ls *.sh); do grep -q $file Makefile || echo $file; done
fib-onlink-tests.sh
in_netns.sh
msg_zerocopy.sh
[Fix]
* 830669e691464c selftests/net: enable msg_zerocopy test
* 1751eb42ddb56b selftests: net: use TEST_PROGS_EXTENDED
* a52b839752aab7 selftests: Add fib-onlink-tests.sh to TEST_PROGS
* Set fib-onlink-tests.sh as executable
They all need to be backported to Bionic.
For the in_netns.sh it's not causing any issue to us when being called by run_afpackettests, but I think it's no harm to fix it to reduce confusions. Commit 1751eb42ddb56b will replace the change in 9faedd64 selftests: net: add in_netns.sh TEST_GEN_
[1] https:/
[2] https:/
[Test]
Run the "net" test suite in the kselftest directory from a patched source tree. fib-onlink-tests.sh and msg_zerocopy.sh tests will be executed.
[Where problems could occur]
This change will bring in more test for our SRU, we might see new failures because of these test in the future.
CVE References
Changed in ubuntu-kernel-tests: | |
assignee: | nobody → Po-Hsu Lin (cypressyew) |
status: | New → In Progress |
description: | updated |
description: | updated |
description: | updated |
Changed in linux (Ubuntu): | |
status: | New → Fix Released |
description: | updated |
tags: | added: 4.15 bionic ubuntu-kernel-selftests |
Changed in linux (Ubuntu Bionic): | |
status: | New → In Progress |
assignee: | nobody → Po-Hsu Lin (cypressyew) |
Changed in linux (Ubuntu Bionic): | |
status: | In Progress → Fix Committed |
This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification- needed- bionic' to 'verification- done-bionic' . If the problem still exists, change the tag 'verification- needed- bionic' to 'verification- failed- bionic' .
If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.
See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation how to enable and use -proposed. Thank you!