simple RGB, HSV & Filtered waveforms not scrolling on macOS

Bug #1928772 reported by Foss-4
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Confirmed
Medium
ronso0

Bug Description

2.3-beta-4017-g82dc1a70f1
macOS 11.3.1

Waveform is not scrolling as expected in some skins.

Deere: Waveform not loaded or shown at all
LateNight > PaleMoon: ok
Shade: ok
Tango: waveform not loaded. Strangely waveform loads once mouse hovers over waveform preview in deck. And more weirdness: waveform will not scroll - it does scroll however whenver the mouse pointer is moved over the wavefrom preview in deck.

____________________
Update
affected renderers: Filtered, HSV, RGB
affected skins: Deere + LateNight + Tango
all renderers work in Shade skin

Revision history for this message
Foss-4 (foss-4) wrote :
Revision history for this message
ronso0 (ronso0) wrote :

Can you please test with Deere and Tango which renderers are affected?

Revision history for this message
Foss-4 (foss-4) wrote :

Deere:
affected: Filtered, HSV, RGB,
ok: Simple - Qt (GL), Filtered - Qt (GL), Simple (GL), Filtered (GL), Filtered (GLSL), RGB (GL), RGB (GLSL), HSV - Qt (GL) ping overlay with pink waveform - that expected? but it scrolls, RGB Qt (GL)

Tango:
affected: Filtered, HSV, RGB,
ok: Simple - Qt (GL), Filtered - Qt (GL), Simple (GL), Filtered (GL), Filtered (GLSL), RGB (GL), RGB (GLSL), HSV - Qt (GL) ping overlay with pink waveform - that expected? but it scrolls, RGB Qt (GL)

Revision history for this message
Foss-4 (foss-4) wrote :

Deere + LateNight + Tango:
affected: Filtered, HSV, RGB,
ok: Simple - Qt (GL), Filtered - Qt (GL), Simple (GL), Filtered (GL), Filtered (GLSL), RGB (GL), RGB (GLSL), HSV - Qt (GL) ping overlay with pink waveform - that expected? but it scrolls, RGB Qt (GL)

Shade:
all waveforms ok

Revision history for this message
ronso0 (ronso0) wrote :

So now all skins except Shade are affected???

Revision history for this message
ronso0 (ronso0) wrote :

@Foss-4
Can you still reproduce this?
Or was there a mac update maybe?

Revision history for this message
Foss-4 (foss-4) wrote :

2.3-beta-4131-g5ae08b96de on macOS 11.4 persisting.

ronso0 (ronso0)
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Medium
description: updated
Revision history for this message
ronso0 (ronso0) wrote :

This is kind of being wokred around already since the default waveform renderers are not affected, and when Mixxx crashes during skin because an affected renderer is selected that wouldn't be stored in the config, so it can at least be restarted without issues.

First I thought that might be caused by waveforms being loaded in Singletons, but that's not the case for affected LateNight (and not necessary in Tango btw).
Then we had Deere previously crashing on macOS if spinnies and waveforms were in the same singleton. But that's also been changed.
Back then, one conclusion was that reparenting the singleton caused issues with the GL context.

So it seems skins are affected as soon as ANY GL widget is loaded into a Singleton.
Solution would be to load individual instances of spinnies and waveforms in every skin, but that would defeat the purpose of saving memory only for getting the simple renderer to work on macOS.

Given the fact (assumption?) that the computers running the minimum supported macOS version 10.12 are powerful enough to not require the simple renderers for performance reasons we can simply hide them on macOS -- and switch to another renderer in case a simple renderer is stored in the config after upgrading to 2.3.

What do you think?

Revision history for this message
Owen Williams (ywwg) wrote :

I agree, Apple laptops have had good GL for at least a decade, I can't imagine a situation where the fallbacks would be needed on that OS

Revision history for this message
ronso0 (ronso0) wrote :

oki, I'll prepare a PR

Revision history for this message
ronso0 (ronso0) wrote :
Changed in mixxx:
status: Confirmed → In Progress
assignee: nobody → ronso0 (ronso0)
milestone: none → 2.3.0
Foss-4 (foss-4)
Changed in mixxx:
status: In Progress → Fix Committed
Revision history for this message
ronso0 (ronso0) wrote :

it's not fixed, just ignored and hidden for now ;)

Changed in mixxx:
status: Fix Committed → Confirmed
ronso0 (ronso0)
summary: - waveform not scrolling on macOS
+ simple TGB, HSV & Filtered waveforms not scrolling on macOS
summary: - simple TGB, HSV & Filtered waveforms not scrolling on macOS
+ simple RGB, HSV & Filtered waveforms not scrolling on macOS
Changed in mixxx:
milestone: 2.3.0 → none
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10416

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.