Docker build env fails on git-review

Bug #1927137 reported by Scott Little
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Critical
Scott Little

Bug Description

Brief Description
-----------------
git-review fails to install/upgrade when creating the
docker builder image.

Trigger was an upstream update to git-review

Severity
--------
critical

Steps to Reproduce
------------------
tb create

Expected Behavior
------------------
docker builder environment is created

Actual Behavior
----------------
docker builder environment fails the creation step

Reproducibility
---------------
100% in absence of a docker cache

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
master & stx.5.0
Any time after Apr 26, 2021

Last Pass
---------
Apr 25, 2021

Timestamp/Logs
--------------
08:31:48.130 Step 23/50 : RUN yum install -y dh-autoreconf curl-devel expat-devel gettext-devel openssl-devel perl-devel zlib-devel asciidoc xmlto docbook2X && cd /tmp && wget https://github.com/git/git/archive/v2.29.2.tar.gz -O git-2.29.2.tar.gz && tar xzvf git-2.29.2.tar.gz && cd git-2.29.2 && make configure && ./configure --prefix=/usr/local && make all doc && make install install-doc && cd /tmp && rm -rf git-2.29.2.tar.gz git-2.29.2 && pip install git-review --upgrade
...
install -m 644 gitcli.7 gitcore-tutorial.7 gitcredentials.7 gitcvs-migration.7 gitdiffcore.7 giteveryday.7 gitfaq.7 gitglossary.7 gitnamespaces.7 gitremote-helpers.7 gitrevisions.7 gitsubmodules.7 gittutorial-2.7 gittutorial.7 gitworkflows.7 /usr/local/share/man/man7
08:42:18.947 make[1]: Leaving directory `/tmp/git-2.29.2/Documentation'
08:42:19.902 Collecting git-review
08:42:20.192 Downloading https://files.pythonhosted.org/packages/52/32/314cdb83186d43661a36d3e49390f818bce4e878b90a0bc980a3c70252bb/git-review-2.1.0.tar.gz (62kB)
08:42:20.576 Complete output from command python setup.py egg_info:
08:42:20.576 Couldn't find index page for 'pbr' (maybe misspelled?)
08:42:20.576 No local packages or download links found for pbr>=4.1.0
08:42:20.576 Traceback (most recent call last):
08:42:20.576 File "<string>", line 1, in <module>
08:42:20.576 File "/tmp/pip-build-PtZxh8/git-review/setup.py", line 20, in <module>
08:42:20.576 setuptools.setup(setup_requires=['pbr>=4.1.0'], pbr=True)
08:42:20.576 File "/usr/lib64/python2.7/distutils/core.py", line 112, in setup
08:42:20.576 _setup_distribution = dist = klass(attrs)
08:42:20.576 File "/usr/lib/python2.7/site-packages/setuptools/dist.py", line 265, in __init__
08:42:20.576 self.fetch_build_eggs(attrs.pop('setup_requires'))
08:42:20.576 File "/usr/lib/python2.7/site-packages/setuptools/dist.py", line 289, in fetch_build_eggs
08:42:20.576 parse_requirements(requires), installer=self.fetch_build_egg
08:42:20.576 File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 618, in resolve
08:42:20.576 dist = best[req.key] = env.best_match(req, self, installer)
08:42:20.576 File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 862, in best_match
08:42:20.576 return self.obtain(req, installer) # try and download/install
08:42:20.576 File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 874, in obtain
08:42:20.576 return installer(requirement)
08:42:20.576 File "/usr/lib/python2.7/site-packages/setuptools/dist.py", line 339, in fetch_build_egg
08:42:20.576 return cmd.easy_install(req)
08:42:20.576 File "/usr/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 617, in easy_install
08:42:20.576 raise DistutilsError(msg)
08:42:20.576 distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('pbr>=4.1.0')
08:42:20.576
08:42:20.576 ----------------------------------------
08:42:20.586 Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-PtZxh8/git-review/

Test Activity
-------------
Build

Workaround
----------
N/A

Scott Little (slittle1)
Changed in starlingx:
assignee: nobody → Scott Little (slittle1)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tools (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/tools/+/789607

Changed in starlingx:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tools (master)

Reviewed: https://review.opendev.org/c/starlingx/tools/+/789607
Committed: https://opendev.org/starlingx/tools/commit/ac05493480f6df6f31d071d29380c1b4f35b70a9
Submitter: "Zuul (22348)"
Branch: master

commit ac05493480f6df6f31d071d29380c1b4f35b70a9
Author: Scott Little <email address hidden>
Date: Tue May 4 12:42:36 2021 -0400

    fix git-review within docker build environment

    'tb create' fails to create a build environment since
    upstream git-review was updated of Apr 26.

    Fix is to install/update pbr ahead of git-review.

    Also, to reduce the likelyhood of this recurring, lock
    down specific versions of the pypi supplied tools we
    know to work.

    Closes-bug: 1927137
    Signed-off-by: Scott Little <email address hidden>
    Change-Id: Ib9fe6fd33de4d637f254ac421cc0427ee6131b65

Changed in starlingx:
status: In Progress → Fix Released
Revision history for this message
Ghada Khalil (gkhalil) wrote :

Screening: Marking as critical given this affects the build. Fix is needed in stx master and the r/stx.5.0 release branch as per the info in the LP description.

Changed in starlingx:
importance: Undecided → Critical
tags: added: stx.5.0 stx.6.0 stx.build stx.cherrypickneeded
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tools (r/stx.5.0)

Fix proposed to branch: r/stx.5.0
Review: https://review.opendev.org/c/starlingx/tools/+/789620

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tools (r/stx.5.0)

Reviewed: https://review.opendev.org/c/starlingx/tools/+/789620
Committed: https://opendev.org/starlingx/tools/commit/f7f2eb3959b7d81a639d75106697acd9c0573adb
Submitter: "Zuul (22348)"
Branch: r/stx.5.0

commit f7f2eb3959b7d81a639d75106697acd9c0573adb
Author: Scott Little <email address hidden>
Date: Tue May 4 12:42:36 2021 -0400

    fix git-review within docker build environment

    'tb create' fails to create a build environment since
    upstream git-review was updated of Apr 26.

    Fix is to install/update pbr ahead of git-review.

    Also, to reduce the likelyhood of this recurring, lock
    down specific versions of the pypi supplied tools we
    know to work.

    Closes-bug: 1927137
    Signed-off-by: Scott Little <email address hidden>
    (cherry picked from commit ac05493480f6df6f31d071d29380c1b4f35b70a9)
    Change-Id: I5842913d34c87a962839fb29f13c05a259006440

Bill Zvonar (billzvonar)
tags: added: in-r-stx50
removed: stx.cherrypickneeded
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tools (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/tools/+/792229

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tools (f/centos8)

Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https://review.opendev.org/c/starlingx/tools/+/792229
Reason: Updated merge coming

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tools (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/tools/+/793627

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tools (f/centos8)
Download full text (30.4 KiB)

Reviewed: https://review.opendev.org/c/starlingx/tools/+/793627
Committed: https://opendev.org/starlingx/tools/commit/d701c6f896dfe440566cc942e3dd71be1f19ae5d
Submitter: "Zuul (22348)"
Branch: f/centos8

commit 7b5f3a45e663866a3c0ca3ca86eb3c92bc7f0210
Author: Scott Little <email address hidden>
Date: Wed May 5 09:56:33 2021 -0400

    fix bad flockflock url pt 2

    A stray '}' character found it's way into my prior update
    titled 'fix bad flockflock url' after testing. The result was
    the following error

    sed: -e expression #1, char 15: unexpected `}'

    This removes the unwanted '}', restoring the prior update
    to its intended form.

    Closes-bug: 1926987
    Signed-off-by: Scott Little <email address hidden>
    Change-Id: I48f4721ccaf121679916b01747243deedf5836cd

commit ac05493480f6df6f31d071d29380c1b4f35b70a9
Author: Scott Little <email address hidden>
Date: Tue May 4 12:42:36 2021 -0400

    fix git-review within docker build environment

    'tb create' fails to create a build environment since
    upstream git-review was updated of Apr 26.

    Fix is to install/update pbr ahead of git-review.

    Also, to reduce the likelyhood of this recurring, lock
    down specific versions of the pypi supplied tools we
    know to work.

    Closes-bug: 1927137
    Signed-off-by: Scott Little <email address hidden>
    Change-Id: Ib9fe6fd33de4d637f254ac421cc0427ee6131b65

commit b96ebc83d859a4a7802a462504817ecec6182a7b
Author: Scott Little <email address hidden>
Date: Mon May 3 13:16:53 2021 -0400

    fix bad flockflock url

    download_mirror.sh fails due to a bad path containing
    ‘stx-tools/centos-mirror-tools/config/centos/flockflock’

    The path is constructed, and the trigger is when an EOL is missing
    from a centos_build_layer.cfg file, causing 'cat' to merge the last
    line of the offending file with the first line of the next file.

    Switch 'cat' to 'grep', which will always ensure an EOL is present.
    Along the way, we can filter out empty lines and comments.

    Closes-bug: 1926987
    Signed-off-by: Scott Little <email address hidden>
    Change-Id: I2404b3415f0f3e2f395c2bcb7a527aa01a488f61

commit 4c3ee114bcbff710c2049626044dd1ddc756cbd9
Author: Joe Slater <email address hidden>
Date: Tue Apr 27 18:50:53 2021 -0400

    screen: fix CVE-2021-26937 segfault

    Advance to screen-4.1.0-0.27.20120314git3c2946.el7_9.x86_64.rpm.

    Closes-bug: 1926372
    Change-Id: I41834e7b1e16153b0632751f59f7ac9f503389da
    Signed-off-by: Joe Slater <email address hidden>

commit e31e0dda7a4c09143d41cd518ab97ea6112d7fb5
Author: Li Zhou <email address hidden>
Date: Tue Apr 13 04:53:50 2021 -0400

    systemd: Upgrade to version 219-78.el7_9.3

    Refer the lst entries to the new version.

    Partial-Bug: #1924691
    Signed-off-by: Li Zhou <email address hidden>
    Change-Id: I557eff6a47f341cc67de02fd59024b28bb6cac84

commit 26db2859dd3a5c060c337b886fd16c4d2d9f93af
Author: Scott Little <email address hidden>
Date: Mon Apr 12 11:21:31 2021 -0400

    Replace basearch references in y...

tags: added: in-f-centos8
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.