tripleo

cli-* playbooks should not be run directly (derived params)

Bug #1926762 reported by John Fulton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Low
John Fulton
tripleo xena-1

Bug Description

Playbooks which are prefixed with "cli-" are not meant to be run directly by TripleO users. Instead, the python-tripleoclient is supposed to execute them.

The cli-derive-local-hci-parameters.yml [0] is meant to be executed directly by an operator as per the docs [1] (though cli-derive-parameters.yaml is meant to be triggered by the python-tripleoclient). Thus, cli-derive-local-hci-parameters.yml should be renamed derive-local-hci-parameters.yml and the documentation updated.

[0] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/playbooks/cli-derive-local-hci-parameters.yml

[1] https://docs.openstack.org/project-deploy-guide/tripleo-docs/latest/features/derived_parameters.html#deriving-hci-paramters-before-a-deployment

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/788938

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-docs (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-docs/+/788940

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/788938
Committed: https://opendev.org/openstack/tripleo-ansible/commit/6b85a3bd4ca4709f27c9629cce9e0d3a108d4c56
Submitter: "Zuul (22348)"
Branch: master

commit 6b85a3bd4ca4709f27c9629cce9e0d3a108d4c56
Author: John Fulton <email address hidden>
Date: Fri Apr 30 11:55:50 2021 +0000

    Remove "cli" prefix from cli-derive-local-hci-parameters.yml

    Playbooks which are prefixed with "cli" are not meant to be
    run directly by TripleO users. The python-tripleoclient is
    supposed to execute them instead. The playbook being renamed
    is not executed by the python-tripleoclient but is instead
    meant to be run directly by the user so update the name to
    follow the convention.

    Old name: cli-derive-local-hci-parameters.yml
    New name: derive-local-hci-parameters.yml

    Closes-Bug: #1926762
    Change-Id: Icea13df0c48028013a7f6e45eabdb5d17cecb1ec

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-docs (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-docs/+/788940
Committed: https://opendev.org/openstack/tripleo-docs/commit/e484fa13493a13f6ad4276715c67c700f26e43ea
Submitter: "Zuul (22348)"
Branch: master

commit e484fa13493a13f6ad4276715c67c700f26e43ea
Author: John Fulton <email address hidden>
Date: Fri Apr 30 08:03:42 2021 -0400

    Update Derived Parameters doc for new name

    Related-Bug: #1926762
    Depends-On: Icea13df0c48028013a7f6e45eabdb5d17cecb1ec
    Change-Id: I2dfe3a97625584fadbd4b331ca1e39a4a118f3e7

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 3.1.0

This issue was fixed in the openstack/tripleo-ansible 3.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.