NRPE checks for canal

Bug #1913226 reported by Andrea Ieri
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canal Charm
Fix Released
Medium
Martin Kalcok

Bug Description

The canal charm doesn't currently provide an nrpe endpoint for monitoring. Failures are sometimes reported via the charm status but that isn't tied to an alerting infrastructure.

Andrea Ieri (aieri)
no longer affects: charm-aws-iam
Revision history for this message
Alvaro Uria (aluria) wrote :

I was able to reproduce this bug.

juju deploy cs:bundle/canonical-kubernetes-canal-932
juju deploy nagios
juju deploy nrpe
juju add-relation nrpe kubernetes-worker
juju add-relation nrpe kubernetes-master
juju add-relation nrpe canal
juju add-relation nrpe nagios:monitors

layer-canal has 3 reactive scripts (calico.py, canal.py, flannel.py) and only flannel has a nrpe check for the init script (systemd) service [1].

If a similar check is added to calico.py [2], there will be 2 handlers reactive to a "nrpe-external-master.available" state. I think it would be more desirable to add both checks on the same helper function, and make a single handler react to the mentioned flag.

Please check a screenshot of the outcome once the check is added.

Tested via:
wget -O calico.gz https://api.jujucharms.com/charmstore/v5/~containers/canal-749/resource/calico/688
wget -O flannel.gz https://api.jujucharms.com/charmstore/v5/~containers/canal-749/resource/flannel/686
juju upgrade-charm --path ~/charms/canal --resource flannel=flannel.gz --resource calico=calico.gz canal

1. https://github.com/charmed-kubernetes/layer-canal/blob/ad039044b4edcc0d7c4d3cca027daffc58195af1/reactive/flannel.py#L210
2. https://pastebin.ubuntu.com/p/58XCpQ5ZdH/

Revision history for this message
Alvaro Uria (aluria) wrote :
George Kraft (cynerva)
Changed in charm-canal:
importance: Undecided → Medium
status: New → Triaged
Changed in charm-canal:
assignee: nobody → Martin Kalcok (martin-kalcok)
status: Triaged → In Progress
tags: added: review-needed
George Kraft (cynerva)
Changed in charm-canal:
status: In Progress → Fix Committed
milestone: none → 1.21
tags: removed: review-needed
Changed in charm-canal:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.