"Instructor" search/browse option does not always display in OPAC

Branch with a fix available at: user/sandbergja/lp1907979_search_by_instructor_setting

Link here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1907979_search_by_instructor_setting

Testing instructions from the commit message:

1) In the Library settings editor, set Course Materials Module Opt In
to true for BR1.
2) In the Library settings editor, set Search by Instructor to true
for BR1.
3) In eg.conf, add the line:
    SetEnv physical_loc 4
4) Restart httpd
5) Go to your OPAC. Note that the OPAC is at the BR1 level, and that
course search and browse options are available.
6) Click Search courses.
7) Note that only two values are available in the qtype dropdown: Course
Name and Course Number.
8) Apply this patch.
9) Repeat steps 5-6.
10) Note that the screen now appropriately consults the value for the
"Search by Instructor" setting at the BR1 level, with an "Instructor"
value now available in the qtype dropdown.

Tested and it works for me. A sign-off branch is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp1907979_search_by_instructor_setting-signoff

Unfortunately, this is not working for me.

I followed the steps above, and I still only get the options of Course Name and Course Number in the search drop downs on the Search for Courses screen.

I double checked the setting.

I double checked that the template with the code change was installed.

I even tried changing where I added the SetEnv physical_loc 4 line in eg.conf.

I restarted Apache after each change to the eg.conf file, and I cleared the cache and site data every time that I went to the browser to do the courses search.

I rebased Gary's branch on current master before testing, so perhaps something has change since December that interferes with this, though I don't see what that could be.

Thanks for testing this, Jason. I can't seem to recreate the behavior you were seeing, including with Garry's commit cherry-picked to today's master.

Any chance that the locg param was included in the URLs you were trying, and that it was set to something other than 4?

Works for me and pushed to master and rel_3_6. Thanks, Jane and Garry!