need eg.orgselect.hopeless.wide_holds

Bug #1895738 reported by Galen Charlton
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.6
Fix Released
Medium
Unassigned

Bug Description

With recent changes to the Angular eg-holds-grid, seed data is now needed for an eg.orgselect.hopeless.wide_holds workstation setting to parallel the one for the grid. Otherwise, interacting with the Hopeless Holds interface results in some console noise:

ERROR Error: Uncaught (in promise): No user or workstation setting type exists for: "eg.orgselect.hopeless.wide_holds".
Create a ws/user setting type or use setLocalItem() to store the value locally.

Evergreen 3.6-beta1

Revision history for this message
Jason Etheridge (phasefx) wrote :

Just noting that more is needed here for removing line noise. After adding the setting type, I get this:

ERROR Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value for 'ng-untouched': 'true'. Current value: 'false'.
    at throwErrorIfNoChangesMode (core.js:5467)
    at bindingUpdated (core.js:13112)
    at checkStylingProperty (core.js:15913)
    at Module.ɵɵclassProp (core.js:15821)
    at NgControlStatus_HostBindings (forms.js:679)
    at setHostBindingsByExecutingExpandoInstructions (core.js:7072)
    at refreshView (core.js:7362)
    at refreshEmbeddedViews (core.js:8408)
    at refreshView (core.js:7340)
    at refreshComponent (core.js:8454)

Changed in evergreen:
assignee: nobody → Jason Etheridge (phasefx)
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.6-beta2 → 3.6-rc
Revision history for this message
Jason Etheridge (phasefx) wrote :

Noting that this also happens with the Pickup Library dialog in the eg2 catalog View Holds interface. I've pushed a branch for the needed workstation setting, but I'm having trouble solving the other issue.

collab/phasefx/lp1895738-hopeless-orgselect @ working/Evergreen.git
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/lp1895738-hopeless-orgselect

tags: added: pullrequest
Changed in evergreen:
assignee: Jason Etheridge (phasefx) → nobody
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.6-rc → 3.6.1
Changed in evergreen:
milestone: 3.6.1 → 3.6.2
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
Revision history for this message
Michele Morgan (mmorgan) wrote :

Adding my signoff for the missing ws setting. I'm no longer seeing any of the console errors described in this bug. As an added bonus, this fix also makes the sticky org unit setting in the Hopeless Holds interface work.

Signoff branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1895738-hopeless-orgselect-signoff

user/mmorgan/lp1895738-hopeless-orgselect-signoff

tags: added: signedoff
Changed in evergreen:
status: New → Confirmed
Changed in evergreen:
milestone: 3.6.3 → 3.6.4
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed down to rel_3_6. Thanks, Jason and Michele!

Changed in evergreen:
milestone: 3.6.4 → 3.7.1
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.