Mixxx

Windows MSIs built with CMake do not install MSVC runtime

Bug #1890955 reported by Be
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Critical
Jan Holthuis
Mixxx 2.3.0

Bug Description

Installing a build from http://downloads.mixxx.org/builds/appveyor/cmake_build/?C=M;O=D on a new Windows VM, Mixxx installs but when trying to run it, it fails with a popup showing this error:

The code execution could not proceed because MSVCP140.dll was not found. Reinstalling the program may fix this problem.

After clicking OK on that dialog, another one appears:

The code execution cannot proceed because VCRUNTIME140.dll was not found. Reinstalling the program may fix this problem.

After installing the MSVC runtime separately, Mixxx starts successfully.

See original description
Be (be.ing)
Changed in mixxx:
importance: Undecided → Critical
milestone: none → 2.3.0
description: updated
Revision history for this message
Uwe Klotz (uklotzde-deactivatedaccount) wrote :

Didn't we upgrade the build VM to MSVC 2017 (15.0)? Then MSVC 2015 (14.0) are the wrong redistributables.

Revision history for this message
Uwe Klotz (uklotzde-deactivatedaccount) wrote :

This could also be the reason for the failing 2.3.0 WiX builds.

Revision history for this message
Be (be.ing) wrote :

These are not built with our build server; they are built with AppVeyor.

Revision history for this message
Uwe Klotz (uklotzde-deactivatedaccount) wrote :

On AppVeyor we also use the "Visual Studio 2017" image.

Revision history for this message
Uwe Klotz (uklotzde-deactivatedaccount) wrote :

Sorry for the confusion, Microsoft versioning. At least the buildserver seems to bundle the correct versions into 2.3-j00019-x86-release-fastbuild-static-55e94982-minimal.zip according to build_environment.log:

C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Redist\MSVC\14.15.26706\vc_redist.x64.exe
1 File(s) copied
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Redist\MSVC\14.15.26706\vc_redist.x86.exe
1 File(s) copied

The SDK version is still 14, while the internal MSVC version is 15.

Revision history for this message
Uwe Klotz (uklotzde-deactivatedaccount) wrote :

https://docs.microsoft.com/cpp/porting/binary-compat-2015-2017

Revision history for this message
Be (be.ing) wrote :

Are you confusing this with Bug #1814273? That was with the legacy SCons build. This bug is about CMake. The CMake builds do not package any version of the MSVC runtime.

Revision history for this message
Uwe Klotz (uklotzde-deactivatedaccount) wrote :

I didn't notice that we already have a bug for the redistributable versioning issue. Added a note there.

Revision history for this message
JosepMa (josepma) wrote :

Correct.

It is a pending task to regenerate the CMake installer with all that the Scons script did, which includes generating multilanguage installer (which require a cumbersome multi-installer generation) and the generation of the exe installer that was a container of both, the runtime and mixxx installers.

And we might include visual studio 2017 or 2019 runtime now ( the are all downward compatible to 2015). If we include 2017, we will probably need some workaround precisely for the bug reported on that bug #1814273 .

Revision history for this message
Be (be.ing) wrote :

https://github.com/mixxxdj/mixxx/pull/3084

Changed in mixxx:
status: New → Fix Committed
assignee: nobody → Jan Holthuis (holthuis-jan)
Daniel Schürmann (daschuer)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10079

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.