kolla

ironic rootwrap filters are not installed in /etc

Bug #1886663 reported by sean mooney on 2020-07-07

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
kolla	Fix Released	Medium	sean mooney	kolla 11.0.0 "victoria"
Ussuri	Fix Released	Medium	Mark Goddard	kolla 10.2.0 "ussuri"
Victoria	Fix Released	Medium	sean mooney	kolla 11.0.0 "victoria"

Bug Description

during the ussuri release cycle ironic moved the definition of some rootwrap filters
form ironic to ironic lib.

https://github.com/openstack/ironic/commit/bfb41571b23d04c9e8fc74caf3d9f94911b8e414
https://github.com/openstack/ironic-lib/commit/bcded1f73f822a0672ca54a43426d871316eb284

due to the fact that kolla installs ironic in a viutural evn and
https://github.com/pypa/wheel/issues/92

when ironic-lib is installed its rootwarap filters are installed withine the venv not to the container root file system.

As a result they are not installed automitaclly and they are not included when
kolla currently copies the filters for the kolla source directory as they are now located in ironic-lib.
https://github.com/openstack/kolla/blob/master/docker/ironic/ironic-base/Dockerfile.j2#L32

sean mooney (sean-k-mooney) on 2020-07-07

Changed in kolla:
assignee:	nobody → sean mooney (sean-k-mooney)

OpenStack Infra (hudson-openstack) on 2020-07-07

Changed in kolla:
status:	New → In Progress

Revision history for this message

Mark Goddard (mgoddard) wrote on 2020-07-09:

https://review.opendev.org/739622

Changed in kolla:
importance:	Undecided → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-07-20: Fix merged to kolla (master)

Reviewed: https://review.opendev.org/739622
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=b6c7110409a5658de6e4d7d468d55a1d7ad49232
Submitter: Zuul
Branch: master

commit b6c7110409a5658de6e4d7d468d55a1d7ad49232
Author: Sean Mooney <email address hidden>
Date: Mon Jul 6 22:51:21 2020 +0000

copy rootwarp files form venv in ironic base

    This change modifies the ironic base container
    to copy rootwarp filters from the virtual
    env rather than the source code directory. This
    is need because some required filters have
    been moved to ironic-lib and are not present in
    the /ironic dir. The rootwrap filters are not
    automitaclly installed in /etc/... due to kolla
    use of virtual envs and https://github.com/pypa/wheel/issues/92

Closes-Bug: #1886663
Change-Id: Idb0a675d92bab8b9a0cf5209f0a06e996e96033c

Changed in kolla:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-07-20: Fix proposed to kolla (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/742003

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-07-21: Fix merged to kolla (stable/ussuri)

Reviewed: https://review.opendev.org/742003
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=a893e6950f5cf969b7e123ec574af8ae4d6befe4
Submitter: Zuul
Branch: stable/ussuri

commit a893e6950f5cf969b7e123ec574af8ae4d6befe4
Author: Sean Mooney <email address hidden>
Date: Mon Jul 6 22:51:21 2020 +0000

copy rootwarp files form venv in ironic base

    Closes-Bug: #1886663
    Change-Id: Idb0a675d92bab8b9a0cf5209f0a06e996e96033c
    (cherry picked from commit b6c7110409a5658de6e4d7d468d55a1d7ad49232)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-01-07: Fix included in openstack/kolla 10.2.0

This issue was fixed in the openstack/kolla 10.2.0 release.

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

auto-github-pypa-wheel #92
[closed bug major] Edit

Bug watches keep track of this bug in other bug trackers.