tripleo

puppet/extraconfig/pre_deploy/per_node.yaml does not work with py3

Bug #1877378 reported by Giulio Fidente
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Giulio Fidente
tripleo ussuri-rc3 "tripleo ussuri-rc3"

Bug Description

Enabling per_node ExtraConfigPre will cause error on deployments because the embedded python code doesn't work with py3

For example:

print json.dumps(cnt.get('4C4C4544-0059-4610-8032-C7C04F584B32', {}))

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.opendev.org/726150

Changed in tripleo:
assignee: nobody → Giulio Fidente (gfidente)
status: Triaged → In Progress
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-rc1 → ussuri-rc3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/726150
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a046de852e76019b407c791acc4755c41ae5c7fe
Submitter: Zuul
Branch: master

commit a046de852e76019b407c791acc4755c41ae5c7fe
Author: Giulio Fidente <email address hidden>
Date: Thu May 7 15:58:42 2020 +0200

    Make per_node.yaml py3 safe

    Use of python print() should work with both py2 and py3 but
    without it script execution fails on py3

    Change-Id: Ifdf4426bf27ffa82f4c2096d2a1670b996b1f53c
    Closes-Bug: 1877378

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/727869

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/train)

Reviewed: https://review.opendev.org/727869
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=45c159f3810c9ad99b61c32cfd267c83eda9b2bf
Submitter: Zuul
Branch: stable/train

commit 45c159f3810c9ad99b61c32cfd267c83eda9b2bf
Author: Giulio Fidente <email address hidden>
Date: Thu May 7 15:58:42 2020 +0200

    Make per_node.yaml py3 safe

    Use of python print() should work with both py2 and py3 but
    without it script execution fails on py3

    Change-Id: Ifdf4426bf27ffa82f4c2096d2a1670b996b1f53c
    Closes-Bug: 1877378
    (cherry picked from commit a046de852e76019b407c791acc4755c41ae5c7fe)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 11.4.0

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.