Same code in tripleo-ansible is able to pass lint test in master and fail in stable/train

Bug #1874153 reported by Sofer Athlan-Guyot
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Unassigned

Bug Description

Hi,

So this lint fails rightly so in stable/train:

https://review.opendev.org/#/c/721692/1/tripleo_ansible/roles/tripleo-redhat-enforce/tasks/enforce_release.yml

- name: unknown failure during call to subscription-manager
  fail:
    msg: >-
      Unknow failure during 'subscription-manager release --show'
      {{subscribed_release.stderr}}

with:

[206] Variables should have spaces before and after: {{ var_name }}
tripleo_ansible/roles/tripleo-redhat-enforce/tasks/enforce_release.yml:32
 {{subscribed_release.stderr}}

and it's correct.

But on master the same code succeed on linters:

https://review.opendev.org/#/c/721292/10/tripleo_ansible/roles/tripleo_redhat_enforce/tasks/enforce_release.yml

(same code)

job openstack-tox-linters — build history
result SUCCESS
buildset e2c74bbfe37e48bc947ca6e4b09404d8
voting true
pipeline check
start_time 2020-04-21T16:46:01
end_time 2020-04-21T16:54:34
duration 8 mins 33 secs
project openstack/tripleo-ansible
branch master
change 721292
patchset 10
ref refs/changes/92/721292/10
ref url https://review.opendev.org/721292
log url https://2c2d6e2f92ea22484239-228e12ec4ef918b0cdd19bdeb189135d.ssl.cf1.rackcdn.com/721292/10/check/openstack-tox-linters/1fe94e6/

Is this discrepancy expected ?

Tags: ci
summary: Same code in tripleo-ansible is able to pass lint test in master and
- fail in stable/stein
+ fail in stable/train
description: updated
Revision history for this message
Sofer Athlan-Guyot (sofer-athlan-guyot) wrote :

One at a time:

2020-04-21 22:52:14.376533 | ubuntu-bionic | [204] Lines should be no longer than 160 chars
2020-04-21 22:52:14.376550 | ubuntu-bionic | /home/zuul/src/opendev.org/openstack/tripleo-ansible/tripleo_ansible/roles/tripleo-redhat-enforce/tasks/enforce_release.yml:18
2020-04-21 22:52:14.376569 | ubuntu-bionic |  https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/16.0/html-single/director_installation_and_usage/index#configuring-the-undercloud-with-environment-files,

this passes master.

Revision history for this message
wes hayutin (weshayutin) wrote :

@sofer this looks like it's passing now in https://review.opendev.org/#/c/721692/. Reopen if I'm incorrect.

Changed in tripleo:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.