Shift+F12 should toggle AutoDJ regardless if AutoDJ feature was selecter ealier
Bug #1870817 reported by
ronso0
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Fix Released
|
Low
|
ronso0 |
Bug Description
to reproduce (1):
(make sure there are tracks in the AutoDJ playlist, quit Mixxx)
* start Mixxx
* don't click anything, just hit Shift+F12 (toggle AutoDJ)
= nothing happens*
* open AutoDJ feature
* hit Shift+F12
= AutoDJ starts
to reproduce (2):
(make sure there are tracks in the AutoDJ playlist, quit Mixxx)
* start Mixxx
* don't click anything, just hit Shift+F12 (toggle AutoDJ)
= nothing happens*
* from anywhere, add track to AutoDJ queue
* hit Shift+F12
= AutoDJ starts
*Log message is `Queue is empty now`from AutoDJProcessor
https:/
summary: |
- Shift+F12 should toggle AutoDJ regardless if AutoDJ processor was active + Shift+F12 should toggle AutoDJ regardless if AutoDJ feature was selecter ealier |
Changed in mixxx: | |
status: | New → In Progress |
assignee: | nobody → ronso0 (ronso0) |
importance: | Undecided → Low |
Changed in mixxx: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Adding m_pAutoDJTableM odel->select( ) at the very top of AutoDJProcessor ::getNextTrackF romQueue( ) fixes the issue. /github. com/mixxxdj/ mixxx/blob/ master/ src/library/ autodj/ autodjprocessor .cpp#L826
https:/
I'm not sure if this the correct fix, but m_pAutoDJTableM odel->select( ); is also called in DlgAutoDJ::onShow() /github. com/mixxxdj/ mixxx/blob/ master/ src/library/ autodj/ dlgautodj. cpp#L219
https:/