Shift+F12 should toggle AutoDJ regardless if AutoDJ feature was selecter ealier

Bug #1870817 reported by ronso0
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
ronso0

Bug Description

to reproduce (1):
(make sure there are tracks in the AutoDJ playlist, quit Mixxx)
* start Mixxx
* don't click anything, just hit Shift+F12 (toggle AutoDJ)
= nothing happens*
* open AutoDJ feature
* hit Shift+F12
= AutoDJ starts

to reproduce (2):
(make sure there are tracks in the AutoDJ playlist, quit Mixxx)
* start Mixxx
* don't click anything, just hit Shift+F12 (toggle AutoDJ)
= nothing happens*
* from anywhere, add track to AutoDJ queue
* hit Shift+F12
= AutoDJ starts

*Log message is `Queue is empty now`from AutoDJProcessor::toggleAutoDJ(bool)
https://github.com/mixxxdj/mixxx/blob/master/src/library/autodj/autodjprocessor.cpp#L399

Tags: autodj library
Revision history for this message
ronso0 (ronso0) wrote :

Adding m_pAutoDJTableModel->select() at the very top of AutoDJProcessor::getNextTrackFromQueue() fixes the issue.
https://github.com/mixxxdj/mixxx/blob/master/src/library/autodj/autodjprocessor.cpp#L826

I'm not sure if this the correct fix, but m_pAutoDJTableModel->select(); is also called in DlgAutoDJ::onShow()
https://github.com/mixxxdj/mixxx/blob/master/src/library/autodj/dlgautodj.cpp#L219

description: updated
ronso0 (ronso0)
summary: - Shift+F12 should toggle AutoDJ regardless if AutoDJ processor was active
+ Shift+F12 should toggle AutoDJ regardless if AutoDJ feature was selecter
ealier
Changed in mixxx:
status: New → In Progress
assignee: nobody → ronso0 (ronso0)
importance: Undecided → Low
Revision history for this message
ronso0 (ronso0) wrote :
Changed in mixxx:
status: In Progress → Fix Committed
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9915

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.