tripleo

swift containers are needlessly restarted on redeploy with no config changes

Bug #1867765 reported by Bogdan Dobrelya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Bogdan Dobrelya
tripleo wallaby-1

Bug Description

That is a sub-case of the closed https://bugs.launchpad.net/tripleo/+bug/1786065 issue. It is still actual for swift containers after https://review.opendev.org/#/c/616116 unwinded the swift
part of the https://review.opendev.org/#/c/590008/ fix.

Bogdan Dobrelya (bogdando)
Changed in tripleo:
importance: Undecided → High
milestone: none → ussuri-3
tags: added: idempotency train-backport-potential
tags: added: queens-backport-potential stein-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.opendev.org/713415

Changed in tripleo:
assignee: nobody → Bogdan Dobrelya (bogdando)
status: New → In Progress
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-3 → ussuri-rc3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (master)

Change abandoned by Bogdan Dobrelya (bogdando) (<email address hidden>) on branch: master
Review: https://review.opendev.org/713415

wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-rc3 → victoria-1
Bogdan Dobrelya (bogdando)
Changed in tripleo:
status: In Progress → Triaged
assignee: Bogdan Dobrelya (bogdando) → nobody
Emilien Macchi (emilienm)
Changed in tripleo:
milestone: victoria-1 → victoria-3
OpenStack Infra (hudson-openstack)
Changed in tripleo:
assignee: nobody → Bogdan Dobrelya (bogdando)
status: Triaged → In Progress
OpenStack Infra (hudson-openstack)
Changed in tripleo:
assignee: Bogdan Dobrelya (bogdando) → Emilien Macchi (emilienm)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Bogdan Dobrelya (bogdando) (<email address hidden>) on branch: master
Review: https://review.opendev.org/713415
Reason: thanks for testing this!

OpenStack Infra (hudson-openstack)
Changed in tripleo:
assignee: Emilien Macchi (emilienm) → Christian Schwede (cschwede)
OpenStack Infra (hudson-openstack)
Changed in tripleo:
assignee: Christian Schwede (cschwede) → Bogdan Dobrelya (bogdando)
Marios Andreou (marios-b)
Changed in tripleo:
milestone: victoria-3 → wallaby-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/713415
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9bc664090741d43fd49857230238fc345bf8d0c9
Submitter: Zuul
Branch: master

commit 9bc664090741d43fd49857230238fc345bf8d0c9
Author: Bogdan Dobrelya <email address hidden>
Date: Tue Mar 17 12:45:15 2020 +0100

    Fix swift containers idempotency

    The change https://review.opendev.org/#/c/616116 unwinded the swift
    part of the https://review.opendev.org/#/c/590008/ changes. So the
    contents of the /var/lib/config-data/swift_ringbuilder config volume
    used to be managed by container-puppet tool. That made swift containers
    always restarted because the puppet-generated rings are always changing
    on each deployment/update execution.

    Restore that unwinded change back and exclude swift rings from the
    management of container-puppet tooling. Instead make init containers
    swift_copy_rings and swift_setup_srv to be always executed (takes
    the same approach as in https://review.opendev.org/#/c/564798/).

    That also fixes the issue with swift_copy_rings seems never been
    executed - at least there is no traces of it in CI jobs logs for swift
    init containers.

    Change-Id: I23b469057e4c47c42601beb166f815ee71147c14
    Closes-Bug: #1867765
    Related-Bug: #1802066
    Related-Bug: #1786065
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 14.0.0

This issue was fixed in the openstack/tripleo-heat-templates 14.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 12.4.2

This issue was fixed in the openstack/tripleo-heat-templates 12.4.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 11.4.0

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 13.2.0

This issue was fixed in the openstack/tripleo-heat-templates 13.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.