Ubuntu
valgrind package

[UBUNTU 20.04] valgrind: Recognize z15 and disable deflate-conversion facility bit

Bug #1866211 reported by bugproxy
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu on IBM z Systems
Fix Released
High
Canonical Foundations Team
valgrind (Ubuntu)
Fix Released
Undecided
Skipper Bug Screeners

Bug Description

Trying to deflate using zlib under valgrind on z15 causes an "unrecognised instruction" crash:

vex s390->IR: unknown insn: B939 A024
==42593== valgrind: Unrecognised instruction at address 0x4acec80.
==42593== at 0x4ACEC80: ??? (in /usr/lib64/libz.so.1.2.11)
==42593== by 0x4AC105B: deflateResetKeep (in /usr/lib64/libz.so.1.2.11)

In fact, the unrecognised instruction is the "deflate conversion call", which is not supported by Valgrind yet. Thus Valgrind should have masked off the respective facility bit, but it didn't.

Upstream commit 3a2711c659ac839934f13e0529e14d6c15325383 fixes this. It will be part of the next Valgrind release 3.16.0.

bugproxy (bugproxy)
tags: added: architecture-s39064 bugnameltc-184223 severity-high targetmilestone-inin2004
Changed in ubuntu:
assignee: nobody → Skipper Bug Screeners (skipper-screen-team)
affects: ubuntu → valgrind (Ubuntu)
Revision history for this message
Frank Heimes (fheimes) wrote :

https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=3a2711c659ac839934f13e0529e14d6c15325383

Frank Heimes (fheimes)
Changed in ubuntu-z-systems:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Canonical Foundations Team (canonical-foundations)
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

But, this patch depends on LTC-163660 which was pospoted to 20.10 release, and these patches don't apply cleanly without the other one.

Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2020-03-19 12:45 EDT-------
(In reply to comment #7)
> But, this patch depends on LTC-163660 which was pospoted to 20.10 release,
> and these patches don't apply cleanly without the other one.
 Hm, I missed the fact that that missed the 20.10 release. Even if that's the case, this bug should be fixed anyhow. I'll attach a minimal patch that you can use instead.

Revision history for this message
bugproxy (bugproxy) wrote : Unset unsupported z14/z15 facility bits

------- Comment on attachment From <email address hidden> 2020-03-19 12:46 EDT-------

This should apply cleanly to Valgrind 3.15. Please let me know if there are any issues/concerns.

Revision history for this message
bugproxy (bugproxy) wrote : Unset unsupported z14/z15 facility bits (fixed)

------- Comment on attachment From <email address hidden> 2020-03-19 12:59 EDT-------

Sorry, the previous patch was incomplete. This is the fixed version.

Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2020-03-25 07:54 EDT-------
@Canonical, please have a look . Many thanks in advance

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package valgrind - 1:3.15.0-1ubuntu9

---------------
valgrind (1:3.15.0-1ubuntu9) focal; urgency=medium

  * Prevent valgrind trying to use unrecognised z14/z15 instructions. LP:
    #1866211

 -- Dimitri John Ledkov <email address hidden> Fri, 03 Apr 2020 11:34:19 +0100

Changed in valgrind (Ubuntu):
status: New → Fix Released
Andrew Cloke (andrew-cloke)
Changed in ubuntu-z-systems:
status: Triaged → Fix Released
Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2020-04-07 04:04 EDT-------
IBM Bugzilla status-> closed, Fix Released with focal

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.