charm should set the application version

https://github.com/charmed-kubernetes/charm-containerd/pull/32

This is still a problem:

tvansteenburgh@slipgate:~$ juju status | head
Model Controller Cloud/Region Version SLA Timestamp
one tannahill-default tannahill/default 2.7.8 unsupported 16:33:31-04:00

App Version Status Scale Charm Store Rev OS Notes
containerd active 4 containerd jujucharms 90 ubuntu
easyrsa 3.0.1 active 1 easyrsa jujucharms 318 ubuntu
etcd 3.4.5 active 3 etcd jujucharms 531 ubuntu
flannel 0.11.0 active 4 flannel jujucharms 492 ubuntu
kubeapi-load-balancer 1.14.0 active 1 kubeapi-load-balancer jujucharms 695 ubuntu exposed
kubernetes-master 1.18.6 active 2 kubernetes-master jujucharms 850 ubuntu
tvansteenburgh@slipgate:~$ juju run -u containerd/0 -- dpkg -l containerd
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-==============-======================-============-=================================
hi containerd 1.3.3-0ubuntu1~18.04.2 amd64 daemon to control runC

Ugh, see paste for easier-to-read output: https://pastebin.ubuntu.com/p/sqmqxQY8MN/

I didn't encounter this on a fresh deploy of stable rev 88. I checked rev 90 and the application_version_set code is there. I'm not seeing any glaring flaws in the code that would cause it to fail, either on new deploy or from an upgrade.

Any reproduction details? Also output from `juju debug-log -i containerd` would help.

Make that `juju debug-log -i containerd --replay`.

I started with the 1.15 bundle, which uses containerd rev 20. Then I upgraded to rev 88. App version is not displayed before or after the upgrade.

Output of `juju debug-log -i containerd --replay --no-tail | pastebinit`:
https://paste.ubuntu.com/p/txTwt9gS7W/

Thanks. It looks like the publish_version_to_juju handler[1] is not running because the containerd.installed flag is not set. That flag did not exist in rev 20. It looks like it never got set post-upgrade.

[1]: https://github.com/charmed-kubernetes/charm-containerd/blob/78e5b90a90c90445e8600b0855e60af9bd5e5e9a/reactive/containerd.py#L238

While we have a version being reported now, it's not correct for containerd (it's the golang version vs the app version). Let's fix this up for our next release.

PR:
https://github.com/charmed-kubernetes/charm-containerd/pull/79

Calico PR:
https://github.com/charmed-kubernetes/layer-calico/pull/89