Incomplete search path(s) for xdelta3 executable

Bug #1864096 reported by Svet Bajlekov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
snapd
Fix Released
High
Zygmunt Krynicki

Bug Description

When determining whether to use deltas or do a full snap download, snapd verifies that an xdelta3 executable is available. However it appears to only look for xdelta3 in (a) the system path, and (b) the core snap.

So in a situation where xdelta3 is not installed in the system path, and the snapd snap is used instead of the core snap, snapd's xdelta3 executable is not found. As a result, snapd does not use deltas but instead does full downloads.

The relevant code for 2.43.3 is at
https://github.com/snapcore/snapd/blob/2.43.3/store/store.go#L1678-L1686
under the getXdelta3Cmd function. Presumably a potential fix is to add filepath.Join(dirs.SnapMountDir, "/snapd/current/usr/bin/xdelta3") to the list of paths being searched.

Svet Bajlekov (svetb)
summary: - Incomplete seatch path(s) for xdelta3 executable
+ Incomplete search path(s) for xdelta3 executable
Zygmunt Krynicki (zyga)
Changed in snapd:
importance: Undecided → High
status: New → Triaged
Zygmunt Krynicki (zyga)
Changed in snapd:
assignee: nobody → Zygmunt Krynicki (zyga)
status: Triaged → In Progress
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

This is fixed by https://github.com/snapcore/snapd/pull/8175 and is now in master.

Changed in snapd:
status: In Progress → Fix Committed
milestone: none → 2.44
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

This was fixed in snapd 2.44 which was since released. Marking it as such.

Changed in snapd:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.