mixxx-2.2.3 linked against QT 5.14 - faders disappear in Deere skins

Bug #1857813 reported by Anton Gubarkov
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
jus

Bug Description

I recently updated the QT library in my laptop and now the faders for 2 decks are visible only when they are in the topmost position. As soon as I move them down, the fader becomes invisible.

I've recorded a short video illustrating the problem.

Tags: skin usability
Revision history for this message
Anton Gubarkov (anton-gubarkov) wrote :
Revision history for this message
Anton Gubarkov (anton-gubarkov) wrote :

my system information:
PF16W6Y2 ~ # uname -a
Linux PF16W6Y2 5.3.18-gentoo #1 SMP PREEMPT Thu Dec 19 22:34:27 MSK 2019 x86_64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz GenuineIntel GNU/Linux

* dependency graph for media-sound/mixxx-2.2.3
 `-- media-sound/mixxx-2.2.3 ~amd64
   `-- dev-db/sqlite-3.30.1 (dev-db/sqlite) amd64
   `-- dev-libs/glib-2.60.7 (dev-libs/glib) ~amd64
   `-- dev-libs/protobuf-3.10.1 (dev-libs/protobuf) ~amd64
   `-- dev-qt/qtconcurrent-5.14.0 (dev-qt/qtconcurrent) ~amd64
   `-- dev-qt/qtcore-5.14.0 (dev-qt/qtcore) ~amd64
   `-- dev-qt/qtdbus-5.14.0 (dev-qt/qtdbus) ~amd64
   `-- dev-qt/qtgui-5.14.0-r1 (dev-qt/qtgui) ~amd64
   `-- dev-qt/qtnetwork-5.14.0 (dev-qt/qtnetwork) ~amd64
   `-- dev-qt/qtopengl-5.14.0 (dev-qt/qtopengl) ~amd64
   `-- dev-qt/qtscript-5.14.0 (dev-qt/qtscript) ~amd64 [scripttools]
   `-- dev-qt/qtsql-5.14.0 (dev-qt/qtsql) ~amd64
   `-- dev-qt/qtsvg-5.14.0 (dev-qt/qtsvg) ~amd64
   `-- dev-qt/qtwidgets-5.14.0 (dev-qt/qtwidgets) ~amd64
   `-- dev-qt/qtx11extras-5.14.0 (dev-qt/qtx11extras) ~amd64
   `-- dev-qt/qtxml-5.14.0 (dev-qt/qtxml) ~amd64
   `-- media-libs/chromaprint-1.4.3 (media-libs/chromaprint) amd64
   `-- media-libs/flac-1.3.3 (media-libs/flac) ~amd64
   `-- media-libs/libid3tag-0.15.1b-r4 (media-libs/libid3tag) amd64
   `-- media-libs/libogg-1.3.4 (media-libs/libogg) ~amd64
   `-- media-libs/libsndfile-1.0.29_pre2_p20191024 (media-libs/libsndfile) ~amd64
   `-- media-libs/libsoundtouch-2.1.2 (>=media-libs/libsoundtouch-1.5) ~amd64
   `-- media-libs/libvorbis-1.3.6-r1 (media-libs/libvorbis) ~amd64
   `-- media-libs/portaudio-19.06.00-r2 (>=media-libs/portaudio-19_pre) ~amd64
   `-- media-libs/portmidi-217-r3 (media-libs/portmidi) ~amd64
   `-- media-libs/rubberband-1.8.2 (media-libs/rubberband) ~amd64
   `-- media-libs/taglib-1.11.1_p20190920-r1 (media-libs/taglib) ~amd64
   `-- media-libs/vamp-plugin-sdk-2.7.1 (media-libs/vamp-plugin-sdk) amd64
   `-- sci-libs/fftw-3.3.8 (sci-libs/fftw) ~amd64
   `-- sys-power/upower-0.99.11 (sys-power/upower) ~amd64
   `-- virtual/libusb-1-r2 (virtual/libusb) amd64
   `-- virtual/opengl-7.0-r2 (virtual/opengl) amd64
   `-- x11-libs/libX11-1.6.9 (x11-libs/libX11) ~amd64
   `-- media-libs/faad2-2.9.0 (media-libs/faad2) amd64
   `-- media-libs/libmp4v2-2.0.0-r1 (media-libs/libmp4v2) ~amd64
   `-- dev-libs/hidapi-0.8.0_rc1_p20140719 (dev-libs/hidapi) amd64
   `-- media-libs/lilv-0.24.6 (>=media-libs/lilv-0.24.2-r3) ~amd64
   `-- media-libs/libmad-0.15.1b-r9 (media-libs/libmad) amd64
   `-- media-libs/opusfile-0.11 (media-libs/opusfile) ~amd64
   `-- media-libs/libshout-2.4.3 (media-libs/libshout) ~amd64
   `-- media-sound/wavpack-5.1.0-r1 (media-sound/wavpack) amd64
   `-- media-video/ffmpeg-4.2.1 (media-video/ffmpeg) ~amd64
   `-- virtual/pkgconfig-1 (virtual/pkgconfig) amd64
   `-- dev-qt/qttest-5.14.0 (dev-qt/qttest) ~amd64
   `-- dev-qt/qtxmlpatterns-5.14.0 (dev-qt/qtxmlpatterns) ~amd64
   `-- dev-util/scons-3.1.2 (dev-util/scons) ~amd64 [python_targets_python2_7]

Revision history for this message
ronso0 (ronso0) wrote :

This looks really weird...
Can you reproduce this with other skins as well?

Also, how does it look weh nyou build master with Qt 5.14?

Revision history for this message
Anton Gubarkov (anton-gubarkov) wrote :

I tested all skins. Only Deere and Deere 64 samplers are affected. All other skins work ok.

Revision history for this message
Daniel Birmingham (dgbirm) wrote :

Having the same issue. Just built mixxx on Manjaro Linux 18.1.5. Problem is isolated to Deere:

Debug [Main]: "Mixxx" "2.3.0-alpha-pre" "(git master r7051; built on: Dec 30 2019 @ 00:23:10; flags: asan=0 battery=1 buildtime=1 bulk=1 color=0 coreaudio=0 faad=0 ffmpeg=1 hid=1 hss1394=0 lilv=1 localecompare=1 macappstore=0 mad=1 mediafoundation=0 modplug=1 optimize=native opus=1 perftools=1 perftools_profiler=1 profiling=0 qt_sqlite_plugin=0 qtkeychain=1 shoutcast=1 shoutcast_internal=0 test=1 tsan=0 ubsan=0 verbose=1 vinylcontrol=1 wv=0)" is starting...
Debug [Main]: Compile time library versions:
Debug [Main]: Qt: 5.14.0

Revision history for this message
jus (jus) wrote :

Can conform the issue since upgrading from QT 5.13 to 5.14.
MacOS 10.14.6 2.3.0-alpha-pre (build master r7055).

There was a svg viewport fix in 5.14 worth investigating
https://bugreports.qt.io/browse/QTBUG-70256

Another aspect of the bug is that stretching images inside mixxx do not work as they used to be.
As seen in OP´s video #1. The crossfader slider stretch is off, compared with QT 5.13.

Also, at least on macOS, there are major performance issues with this specific QT version.
On my machine, mixxx is at 100% CPU even while idle, just trying to render images.

It appears there have been some changes to the graphics stack .
https://wiki.qt.io/Qt_5.14_Release

As a stop-gap solution, i simplified the affected svg graphics for the Deere skin. There was some transformation going on (that rotates a shape around the point 0,0), also the unscaled handle graphics were bigger than the slider graphics. That was apparently not an issue until now.

At last, i added a maximum size for the crossfader slider image to stop the crossfader handle from overflowing the background graphic.

 As said, apparently there is an issue with mixxx internal STRETCH image function. The crossfader slider graphic ``slider-crossfader.svg`` does not stretch (expand) correct to the sliders widget size, but the ``slider-crossfader-AutoDJ.svg`` , active when using AUTODJ and defined in ``style.qss`` does.

Please test.

Changed in mixxx:
status: New → Confirmed
Revision history for this message
jus (jus) wrote :
Changed in mixxx:
status: Confirmed → In Progress
assignee: nobody → jus (jus)
importance: Undecided → Low
tags: added: skin usability
summary: - mixxx-2.2.3 linked against QT 5.14 - faders disappear
+ mixxx-2.2.3 linked against QT 5.14 - faders disappear in Deere skins
Changed in mixxx:
milestone: none → 2.3.0
Changed in mixxx:
status: In Progress → Fix Committed
Revision history for this message
pisingallo (pisingallo) wrote :

any chance this could be backported to the v2.2.3 branch? This is very important

Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9854

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.