tripleo

paunch does not honor environment when an exec is invoked

Bug #1855932 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Emilien Macchi
tripleo ussuri-1

Bug Description

Currently, environment vars in THT are only honored when starting a container via run. Execs (like done for bootstraps) do not actually get environment variables set so you can't reference them when trying to run a command.

Alex Schultz (alex-schultz)
tags: added: queens-backport-potential rocky-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/698332

Changed in tripleo:
assignee: nobody → Alex Schultz (alex-schultz)
status: Triaged → In Progress
OpenStack Infra (hudson-openstack)
Changed in tripleo:
assignee: Alex Schultz (alex-schultz) → Emilien Macchi (emilienm)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to paunch (master)

Reviewed: https://review.opendev.org/698329
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=b5be45067ac1e7d3b08458e2943e8de046aeee7b
Submitter: Zuul
Branch: master

commit b5be45067ac1e7d3b08458e2943e8de046aeee7b
Author: Emilien Macchi <email address hidden>
Date: Tue Dec 10 16:42:39 2019 -0500

    builder: include environment when running an exec

    Some container execs have an environment, let's make sure they are
    included when running exec.

    Closes-Bug: #1855932
    Change-Id: Ic2e2c2d50f5883f7db28768ba215e74bcbf9fd8b

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to paunch (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/698928

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to paunch (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/698929

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to paunch (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/698932

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to paunch (stable/stein)

Related fix proposed to branch: stable/stein
Review: https://review.opendev.org/698933

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/698332
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=6f90cd8528abbcfeb1f9f8180ca048704b6ffed0
Submitter: Zuul
Branch: master

commit 6f90cd8528abbcfeb1f9f8180ca048704b6ffed0
Author: Alex Schultz <email address hidden>
Date: Tue Dec 10 15:08:43 2019 -0700

    Update environment var for keystone bootstrap

    Related-Bug: #1855932

    Change-Id: I6907729bca667459466834276513e9f0233d10d0
    Depends-On: https://review.opendev.org/#/c/698329
    Depends-On: https://review.opendev.org/#/c/698480

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (stable/train)

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/699017

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (stable/stein)

Related fix proposed to branch: stable/stein
Review: https://review.opendev.org/699019

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (stable/rocky)

Related fix proposed to branch: stable/rocky
Review: https://review.opendev.org/699020

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to paunch (stable/stein)

Reviewed: https://review.opendev.org/698933
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=0f20a8eb1d6f2ee6865725a0cbd28ee603f4cccc
Submitter: Zuul
Branch: stable/stein

commit 0f20a8eb1d6f2ee6865725a0cbd28ee603f4cccc
Author: Emilien Macchi <email address hidden>
Date: Mon Oct 7 22:03:47 2019 -0400

    builder: allow to pass a dict to 'environment'

    To allow to pass container environment as a dict instead of a list.
    It's backward compatible, a list can still be passed.

    We introduce a new function "list_or_dict_arg" so we can re-use it for
    other parameters later if needed.

    Related-Bug: #1855932
    Change-Id: I85999889d3328dc9d2116b8539ac959b39cb833a
    (cherry picked from commit cfa2fc51ab5412436063b73b842141a8d788911a)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to paunch (stable/stein)

Reviewed: https://review.opendev.org/698929
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=d9117c4796ea075b65cf09dd92b78bd9d037db52
Submitter: Zuul
Branch: stable/stein

commit d9117c4796ea075b65cf09dd92b78bd9d037db52
Author: Emilien Macchi <email address hidden>
Date: Tue Dec 10 16:42:39 2019 -0500

    builder: include environment when running an exec

    Some container execs have an environment, let's make sure they are
    included when running exec.

    Closes-Bug: #1855932
    Change-Id: Ic2e2c2d50f5883f7db28768ba215e74bcbf9fd8b
    (cherry picked from commit b5be45067ac1e7d3b08458e2943e8de046aeee7b)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to paunch (stable/rocky)

Reviewed: https://review.opendev.org/698932
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=0108ad789a087a9581c5cc4fbb3547f7aff45662
Submitter: Zuul
Branch: stable/rocky

commit 0108ad789a087a9581c5cc4fbb3547f7aff45662
Author: Alex Schultz <email address hidden>
Date: Fri Dec 13 08:21:46 2019 -0700

    builder: include environment when running an exec

    Some container execs have an environment, let's make sure they are
    included when running exec.

    NOTE: This is for Rocky and below as docker was the only supported
    method in these versions. Additionally in Rocky and below, the
    environment was a list and not a dictionary so we only support a list
    version for the environment.

    Closes-Bug: #1855932
    Change-Id: Ic2e2c2d50f5883f7db28768ba215e74bcbf9fd8b
    (cherry picked from commit b5be45067ac1e7d3b08458e2943e8de046aeee7b)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to paunch (stable/train)

Reviewed: https://review.opendev.org/698928
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=b2f3c3c464b59487c5f0b876a7932058da1b949b
Submitter: Zuul
Branch: stable/train

commit b2f3c3c464b59487c5f0b876a7932058da1b949b
Author: Emilien Macchi <email address hidden>
Date: Tue Dec 10 16:42:39 2019 -0500

    builder: include environment when running an exec

    Some container execs have an environment, let's make sure they are
    included when running exec.

    Closes-Bug: #1855932
    Change-Id: Ic2e2c2d50f5883f7db28768ba215e74bcbf9fd8b
    (cherry picked from commit b5be45067ac1e7d3b08458e2943e8de046aeee7b)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (stable/stein)

Change abandoned by Emilien Macchi (<email address hidden>) on branch: stable/stein
Review: https://review.opendev.org/699019
Reason: Clearing the gate now, see https://bugs.launchpad.net/tripleo/+bug/1856864
Do not restore the patch yet, I'll take care of it when the gate is back online.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-heat-templates (stable/train)

Reviewed: https://review.opendev.org/699017
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=58521422fc5b1d79d1a151615293603afa8c287d
Submitter: Zuul
Branch: stable/train

commit 58521422fc5b1d79d1a151615293603afa8c287d
Author: Alex Schultz <email address hidden>
Date: Tue Dec 10 15:08:43 2019 -0700

    Update environment var for keystone bootstrap

    Related-Bug: #1855932

    Change-Id: I6907729bca667459466834276513e9f0233d10d0
    Depends-On: https://review.opendev.org/#/c/698928/
    (cherry picked from commit 6f90cd8528abbcfeb1f9f8180ca048704b6ffed0)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-heat-templates (stable/rocky)

Reviewed: https://review.opendev.org/699020
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d35bfa0b866321857e84a66645e304a2bcc78eaa
Submitter: Zuul
Branch: stable/rocky

commit d35bfa0b866321857e84a66645e304a2bcc78eaa
Author: Alex Schultz <email address hidden>
Date: Fri Dec 13 14:08:36 2019 -0700

    Update environment var for keystone bootstrap

    Related-Bug: #1855932

    Change-Id: I6907729bca667459466834276513e9f0233d10d0
    Depends-On: https://review.opendev.org/#/c/698932/
    (cherry picked from commit 6f90cd8528abbcfeb1f9f8180ca048704b6ffed0)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-heat-templates (stable/stein)

Reviewed: https://review.opendev.org/699019
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=aa660ce845667cbb9143e1537791126850f3f150
Submitter: Zuul
Branch: stable/stein

commit aa660ce845667cbb9143e1537791126850f3f150
Author: Alex Schultz <email address hidden>
Date: Tue Dec 10 15:08:43 2019 -0700

    Update environment var for keystone bootstrap

    Related-Bug: #1855932

    Change-Id: I6907729bca667459466834276513e9f0233d10d0
    Depends-On: https://review.opendev.org/#/c/698929/
    (cherry picked from commit 6f90cd8528abbcfeb1f9f8180ca048704b6ffed0)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/paunch 5.3.1

This issue was fixed in the openstack/paunch 5.3.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (stable/queens)

Related fix proposed to branch: stable/queens
Review: https://review.opendev.org/706141

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to paunch (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/706862

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to paunch (stable/queens)

Reviewed: https://review.opendev.org/706862
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=5fa3028d11f34c69cf1a428b193e1361f72669a6
Submitter: Zuul
Branch: stable/queens

commit 5fa3028d11f34c69cf1a428b193e1361f72669a6
Author: Alex Schultz <email address hidden>
Date: Fri Dec 13 08:21:46 2019 -0700

    builder: include environment when running an exec

    Some container execs have an environment, let's make sure they are
    included when running exec.

    NOTE: This is for Rocky and below as docker was the only supported
    method in these versions. Additionally in Rocky and below, the
    environment was a list and not a dictionary so we only support a list
    version for the environment.

    Closes-Bug: #1855932
    Change-Id: Ic2e2c2d50f5883f7db28768ba215e74bcbf9fd8b
    (cherry picked from commit b5be45067ac1e7d3b08458e2943e8de046aeee7b)
    (cherry picked from commit 0108ad789a087a9581c5cc4fbb3547f7aff45662)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-heat-templates (stable/queens)

Reviewed: https://review.opendev.org/706141
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=8618151d88b437889e2db5a262b78ca908c50136
Submitter: Zuul
Branch: stable/queens

commit 8618151d88b437889e2db5a262b78ca908c50136
Author: Alex Schultz <email address hidden>
Date: Fri Dec 13 14:08:36 2019 -0700

    Update environment var for keystone bootstrap

    Closes-Bug: #1861248
    Related-Bug: #1855932

    Change-Id: I6907729bca667459466834276513e9f0233d10d0
    Depends-On: https://review.opendev.org/#/c/706862/
    (cherry picked from commit 6f90cd8528abbcfeb1f9f8180ca048704b6ffed0)
    (cherry picked from commit d35bfa0b866321857e84a66645e304a2bcc78eaa)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/paunch 6.0.1

This issue was fixed in the openstack/paunch 6.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/paunch rocky-eol

This issue was fixed in the openstack/paunch rocky-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/paunch queens-eol

This issue was fixed in the openstack/paunch queens-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/paunch stein-eol

This issue was fixed in the openstack/paunch stein-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.