OverBar misaligned relative to text

Bug #1852037 reported by Johannes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Committed
High
Jeff Young

Bug Description

What happened to the OverBar feature? Refer attached screen shot.

Application: LibEdit
Version: (5.99.0-344-g6b4febc3c-dirty), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.58.0 GnuTLS/3.5.18 zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1 (+libidn2/2.0.4) nghttp2/1.30.0 librtmp/2.3
Platform: Linux 4.15.0-68-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    Build date: Nov 11 2019 14:27:19
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.22
    Boost: 1.65.1
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.58.0
    Compiler: GCC 9.2.1 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Tags: eeschema ui
Revision history for this message
Johannes (jos+) wrote :
Revision history for this message
eelik (eelik) wrote :

It doesn't happen in 5.1. In 5.99 the tilde mark ~ is visible besides the overbar.

Application: LibEdit
Version: (5.99.0-340-g1b14a38b0), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.66.0 OpenSSL/1.1.1d (Schannel) zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.21.0 (+libidn2/2.1.1) nghttp2/1.39.2
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    Build date: Nov 10 2019 22:08:54
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.71.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.66.0
    Compiler: GCC 9.2.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Revision history for this message
Johannes (jos+) wrote :

It was ok for some time in 5.99 until recently.

What happens is that instead of the first over barred character the ~ itself gets drawn.
This happens not only to pins. A net label shows the same behavior.

e.g. ~test~ing gets rendered as see attached.

Revision history for this message
Ian McInerney (imcinerney) wrote :

There has been some work recently that has affected the fonts displayed in Eeschema, so we are seeing some residual bugs from this.

(see lp:1851880).

Changed in kicad:
status: New → Triaged
milestone: none → 6.0.0-rc1
importance: Undecided → Low
tags: added: eeschema ui
Revision history for this message
Jeff Young (jeyjey) wrote :

Well rats. I tried to fix the three-tilda corner case and appear to have broken the single-tilda case.

Changed in kicad:
assignee: nobody → Jeff Young (jeyjey)
status: Triaged → In Progress
Revision history for this message
Johannes (jos+) wrote :

Looked at lp:1851880. Just compiled the most recent 5.99.0-347-g4d6b0cc3f

The tilde 'effect' is still the unchanged.

Johannes (jos+)
Changed in kicad:
status: In Progress → New
status: New → Confirmed
status: Confirmed → In Progress
Revision history for this message
Jeff Young (jeyjey) wrote :

Turned out to be an earlier change that broke it.

Still mine, though. :eek: (Will gitlab allow emojis?)

Changed in kicad:
importance: Low → High
Revision history for this message
Jeff Young (jeyjey) wrote :

(Moved this to High as it broke the core functionality rather than the corner-case.)

Revision history for this message
Johannes (jos+) wrote :

Think so too since I had a look through the code and it took me very deep inside.
Still. I couldn't put my finger on it (yet). Bummer.

Revision history for this message
Johannes (jos+) wrote :

Yeepy, that worked.

Jeff Young (jeyjey)
Changed in kicad:
status: In Progress → Fix Committed
Revision history for this message
Johannes (jos+) wrote :

Current fix only partially covers the overbar issue.
Net names displayed in pcbnew still show misalignment.
See attached screen shot.

Revision history for this message
Michael Kavanagh (michaelkavanagh) wrote :

@Johannes, when making comments like this please copy the full version information from About KiCad -> Copy Version Info so people we're all on the same page regarding build versions etc.

Revision history for this message
Johannes (jos+) wrote :

Application: Pcbnew
Version: (5.99.0-391-gf5bdb3f89), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.58.0 GnuTLS/3.5.18 zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1 (+libidn2/2.0.4) nghttp2/1.30.0 librtmp/2.3
Platform: Linux 4.15.0-68-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    Build date: Nov 18 2019 10:44:35
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.22
    Boost: 1.65.1
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.58.0
    Compiler: GCC 9.2.1 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Changed in kicad:
status: Fix Committed → New
Revision history for this message
Jeff Young (jeyjey) wrote :

The bitmap text routines have the same issue as the stroke font ones....

Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 89ace3b0d029d74c6bb2a11cb506a1ed2508738e
https://git.launchpad.net/kicad/patch/?id=89ace3b0d029d74c6bb2a11cb506a1ed2508738e

Changed in kicad:
status: New → Fix Committed
Revision history for this message
Johannes (jos+) wrote :

Thanks Jeff.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.