Terminator should not hard-depend on python-gnome

Bug #184809 reported by C.Kontros
4
Affects Status Importance Assigned to Milestone
Terminator
Fix Released
Medium
Chris Jones

Bug Description

While trying Terminator in a Fluxbox only install it fails to load because of hard-depending on python-gnome. Removing "gnome" from line 41 of /usr/bin/terminator allows Terminator to start bug gives an error.

"WARNING: Unable to find profile None. Continue with default values..."

Revision history for this message
Chris Jones (cmsj) wrote :

gnome is only used for opening urls, which ought to be possible another way, so we should look for ways to degrade gracefully on this.

Changed in terminator:
importance: Undecided → Medium
milestone: none → 1.0-beta
status: New → Triaged
Revision history for this message
Chris Jones (cmsj) wrote :

at worst we could just look for debian's preferred browser, then firefox, konqueror and opera.
It would be better to look at what libgnome is doing and emulate that behaviour (at which point we could drop the gnome-python dependency entirely)

Revision history for this message
Emilio Pozuelo Monfort (pochu) wrote :

Isn't webbrowser module good enough? It's cross platform (will open the default desktop, no matter if it's Linux, Mac OS, Windows...). Also it won't add a new dependency as it's in the python core modules.

http://docs.python.org/lib/module-webbrowser.html

Revision history for this message
Chris Jones (cmsj) wrote : Re: [Bug 184809] Re: Terminator should not hard-depend on python-gnome

Hi

Emilio Pozuelo Monfort wrote:
> Isn't webbrowser module good enough? It's cross platform (will open the

yes that looks perfect :)

Cheers,
--
Chris Jones
  <email address hidden>
   www.tenshu.net

Revision history for this message
Chris Jones (cmsj) wrote :

This is actually much more tricky than I expected.
If we use webbrowser we are no longer able to open email addresses in the user's email program, or any other protocol in their specified handler. Everything will just open in a Web Browser.
I think a better option is to try and use gnome, but if it's not available, fallback on webbrowser.

Revision history for this message
Chris Jones (cmsj) wrote :

Actually this was much easier than I expected. We now gracefully fall back on python's webbrowser module where the gnome module is not present. Users without the gnome module will be required to have their browser handle all URIs.

Changed in terminator:
assignee: nobody → cmsj
status: Triaged → Fix Committed
Chris Jones (cmsj)
Changed in terminator:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.