Node discover fails to find kernel image

Bug #1845698 reported by Daniel King
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Daniel King

Bug Description

Description
===========

Attempting to run `openstack overcloud node discover` fails to find bm-deploy-kernel image in glance. An update three months ago to `openstack overcloud image build` removed the upload of those images to glance.

Steps to reproduce
==================

Following instructions here: https://docs.openstack.org/project-deploy-guide/tripleo-docs/latest/deployment/install_undercloud.html

Then, on this page: https://docs.openstack.org/project-deploy-guide/tripleo-docs/latest/provisioning/node_discovery.html#scanning-bmc-range

$ echo "$DIB_YUM_REPO_CONF"
/etc/yum.repos.d/delorean* /etc/yum.repos.d/tripleo-centos-ceph*.repo

$ openstack overcloud image build

$ openstack overcloud image upload

$ openstack overcloud node discover --range 10.64.1.0/24 --credentials "root:$pass"

Expected result
===============

Running `openstack overcloud node discover --range <range> --credentials "user:pass"` should be able to discover nodes and set the deploy image.

Expected: "Successfully registered node UUID ..."

Here is what I got later, after I modified the code at overcloud_node.py:

http://paste.openstack.org/show/779607/

Actual result
=============

"Kernel image bm-deploy-kernel not found in Glance"

http://paste.openstack.org/show/779606/

Additional information
======================

After investigating further, I discovered that the bm-* images were no longer intended to be uploaded to glance. The change happened a couple months ago:

https://github.com/openstack/python-tripleoclient/commit/7ad1b812fc5e2504e130e0997b741ce3b891f4db#diff-84904835afd9ead54ffafbffda5079f6

At that time, there were some changes made to overcloud_node.py, but only for classes ImportNode and ConfigureNode, and none for DicscoverNode. Inside of DiscoverNode, I found that the default for deploy_kernel and deploy_ramdisk were still using the bm-* images.

I was able to get a successful status from the code by altering the defaults:

http://paste.openstack.org/show/779526/

Which gave the expected result, mentioned above:

http://paste.openstack.org/show/779607/

Also, it seems that this issue may be related to the issue at https://bugs.launchpad.net/tripleo/+bug/1749656, though I haven't been able to replicate that yet.

There are also a few mentions of the bm-* images in the tests as well.

Environment
===========
Stein

Undercloud os: CentOS Linux release 7.6.1810 (Core)

Installed Packages
Name : python2-tripleoclient
Arch : noarch
Version : 12.1.1
Release : 0.20190916222855.c28df72.el7
Size : 2.4 M
Repo : installed
From repo : delorean
Summary : OpenstackClient plugin for tripleoclient
URL : https://pypi.python.org/pypi/python-tripleoclient
License : ASL 2.0
Description :
            : python-tripleoclient is a Python plugin to OpenstackClient
            : for TripleO <https://github.com/openstack/python-tripleoclient>.

Logs & Configs
==============

http://paste.openstack.org/show/779704/

Changed in tripleo:
status: New → Triaged
importance: Undecided → Medium
milestone: none → ussuri-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/686064

Changed in tripleo:
assignee: nobody → Daniel King (dankingtech)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/686064
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=3f5ddb8fb4029b0a57ab9461595a1de002f232f5
Submitter: Zuul
Branch: master

commit 3f5ddb8fb4029b0a57ab9461595a1de002f232f5
Author: Daniel King <email address hidden>
Date: Tue Oct 1 17:46:42 2019 -0400

    Removed references to bm-deploy images

    Previously, kernel and ramdisk images had been
    removed from glance in favor of using them directly from the
    filesystem. However, some references to these images remained in a
    couple of test scripts and also for node discovery where they were
    being used as the default. The images being used were
    bm-deploy-kernel and bm-deploy-ramdisk.

    The change requiring this update was made in commit 7ad1b812fc and
    can be found at review https://review.opendev.org/#/c/663897/

    In tripleoclient/v1/overcloud_node.py, replaced the default kernel and
    ramdisk image names with paths to the current default locations, and
    adjusted tripleoclient/tests/v1/overcloud_node/test_overcloud_node.py
    to use these paths in the test.

    In tripleoclient/tests/v1/overcloud_image/test_overcloud_image.py,
    removed mentions of these images in the image list as they no longer
    appear as available images in a live setup. This rule change would
    have correctly caused test failures for missing images before
    overcloud_node.py was updated.

    Closes-Bug: #1845698
    Change-Id: Ia556e09b7e92ed16e50061ccfbd002af61252092

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 12.3.0

This issue was fixed in the openstack/python-tripleoclient 12.3.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.