nova handler "Restart nova-libvirt container" fails

I worked around it by destroying everything and re-deploying from scratch so I can't try possible suggestions anymore. Would still be cool to avoid this for others.

For future reference, the best way to debug an issue like this would be to add debug tasks to display the various variables that are referenced here.

https://docs.ansible.com/ansible/latest/modules/debug_module.html

[Expired for kolla-ansible because there has been no activity for 60 days.]

This happens for me as well on 8.0.1 after restarting the node (it's AIO). I narrowed it down to `ceph_conf` in https://github.com/openstack/kolla-ansible/blob/8.0.1/ansible/roles/nova/handlers/main.yml#L81 (seems to be a string instead of `none`).

I have reproduced something similar:

---
- hosts: localhost
  tasks:
    - command: 'true'
      when: none_var is not none and none_var.changed
      vars:
        none_var: "{{ {} if foo is defined else none }}"

ansible-playbook t.yml

PLAY [localhost] *******************************************************************************************************************************************************************************************

TASK [Gathering Facts] *************************************************************************************************************************************************************************************
ok: [localhost]

TASK [command] *********************************************************************************************************************************************************************************************
fatal: [localhost]: FAILED! => {"msg": "The conditional check 'none_var is not none and none_var.changed' failed. The error was: error while evaluating conditional (none_var is not none and none_var.changed): 'unicode object' has no attribute 'changed'\n\nThe error appears to be in '/tmp/t.yml': line 4, column 7, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n tasks:\n - command: 'true'\n ^ here\n"}

PLAY RECAP *************************************************************************************************************************************************************************************************
localhost

If I change it to this, it works:

---
- hosts: localhost
  tasks:
    - command: 'true'
      when: none_var is mapping and none_var.changed
      vars:
        none_var: "{{ foo if foo is defined else '' }}"

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/698680

This only affects the Stein release since https://review.opendev.org/#/c/636122/ was not backported.

It looks like it was included in stein, not needing backporting...

Reviewed: https://review.opendev.org/698680
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=067b55505df17995538564c765cb6676218466e1
Submitter: Zuul
Branch: stable/stein

commit 067b55505df17995538564c765cb6676218466e1
Author: Mark Goddard <email address hidden>
Date: Thu Dec 12 10:09:02 2019 +0000

    Fix nova and cinder handlers with no ceph

    Stein only

    If we deploy nova or cinder without internal or external ceph
    configured, and there are no config or container changes, then the
    following task may fail:

    RUNNING HANDLER [nova : Restart nova-libvirt container]

    The error is in evaluating the conditionals:

    'str object' has no attribute 'changed'

    Thank you to Emanuel Evans (shosti) for determining that ceph_conf is the issue
    here. The problem is that if ceph_confs is undefined, then we set ceph_conf to
    {{ none }}, however due to the 'magic' of Jinja this evaluates to a string. The
    check for none therefore fails, and we look up an attribute 'changed' on a
    string.

    This change fixes the issue by changing the condition from 'is not none' to 'is
    mapping'. We also change the value to an empty string, to make it clear that it
    does not end up as None.

    Change-Id: I240ecd6b9a4ef09ef9cbc3f58c9c0169c73c5e58
    Closes-Bug: #1842913

This issue was fixed in the openstack/kolla-ansible 8.1.0 release.