Mixxx

use [Library],GoToItem to trigger 'Close' in messages like "File not found"

Bug #1841390 reported by ronso0
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Wishlist
ronso0
Mixxx 2.3.0

Bug Description

Currently, mouse or keyboard presses are the only way to close popup windows like error messages.
It would be way more convenient if we also could use [Library],GoToItem

Revision history for this message
ronso0 (ronso0) wrote :

my approach would be to filter for focusWidget class name 'QMessageBox' in /library/librarycontrol.cpp and map Up/Down key to emulate a Tab key, GoToItem would be spacebar

is there any quicker or more elegant solution?

Daniel Schürmann (daschuer)
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
Daniel Schürmann (daschuer) wrote :

I think the normal solution is for keyboard control, using Tab and Enter.

If we keep in line with it, it would be "[Library]", "MoveFocus"
Does it fit to your mapping? Does this already work?

If not, a cleaner solution would be so subclass 'QMessageBox' and handle the UP/Down keys there.

Revision history for this message
Daniel Schürmann (daschuer) wrote :

I think "[Library]", "MoveFocus" already works.

Revision history for this message
ronso0 (ronso0) wrote :

yes, also MoveUp/Down 'works' as it issues Tab to refocus the library.
The QToolButtons have focus and Enter or Spacebar would work.
To avoid any unexpected behaviour I'd like to make sure it's a QMessagebox we're in and not some library feature or other widget. How would I find out?
Would QApplication::activeModalWidget() or QApplication::activePopupWidget() be sufficient?

Daniel Schürmann (daschuer)
tags: added: gui
removed: ui
ronso0 (ronso0)
tags: added: midi usability
Revision history for this message
ronso0 (ronso0) wrote :

https://github.com/mixxxdj/mixxx/pull/3199

Changed in mixxx:
status: Confirmed → In Progress
assignee: nobody → ronso0 (ronso0)
milestone: none → 2.3.0
ronso0 (ronso0)
Changed in mixxx:
status: In Progress → Fix Committed
Daniel Schürmann (daschuer)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9727

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.