Eeschema has Save and Save All

Bug #1840383 reported by Seth Hillbrand
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Committed
Undecided
Seth Hillbrand

Bug Description

The horizontal toolbar is tied to "Save All" while the Hotkey is set to "Save"

While we do use a document-based file format, I don't think that there's a good usecase for differentiating between "Save" and "Save All". In a multi-document interface, you might have multiple, /independent/ documents open at once, so having two kinds of Save makes sense.

Eeschema can never have multiple independent sheets open. They can only be hierarchically linked, so allowing one sheet to be saved but another to not be invites more trouble than it is meant to avoid.

Application: Eeschema
Version: (5.1.0-1541-g911902147), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.0 OpenSSL/1.1.1c zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) libssh2/1.8.0 nghttp2/1.36.0 librtmp/2.3
Platform: Linux 4.19.0-5-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.64.0
    Compiler: GCC 8.3.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON
    KICAD_STDLIB_DEBUG=OFF
    KICAD_STDLIB_LIGHT_DEBUG=OFF
    KICAD_SANITIZE=OFF

Tags: eeschema
Revision history for this message
Jeff Young (jeyjey) wrote :

I agree, but this kind of gets us back to the whole undo discussion. If a linked document should be treated as a single document for save, then it should be treated as a single document for undo.

tags: added: eeschema
Changed in kicad:
milestone: none → 6.0.0-rc1
Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 0d3f6a493006fc1e343d53f52a093d141168be0b
https://git.launchpad.net/kicad/patch/?id=0d3f6a493006fc1e343d53f52a093d141168be0b

Changed in kicad:
status: New → Fix Committed
assignee: nobody → Seth Hillbrand (sethh)
Revision history for this message
Seth Hillbrand (sethh) wrote :

@Jeff- I agree it has similarities. I've pushed a patch to keep the save function as "Save the full schematic". Save as remains saving the current sheet only.

I'm agnostic on the undo/redo issue. I understand the concern about causing changes where the user doesn't see them. But I think we can separate the two issues without confusing users.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.