Widelands Website

Better handling of 'This map requires widelands Version >x'

Bug #1833662 reported by kaputtnik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Widelands Website
Fix Released
Undecided
Unassigned
widelands
Won't Fix
Undecided
Unassigned
widelands build21-rc1

Bug Description

Just saw that we have already a map which needs a widelands version > 20. See comments in https://wl.widelands.org/maps/struggling-for-a-new-home-again/

Currently the distinction regarding the needed widelands version is made from the amount of possible players. I think we need another way to get the needed version. Maybe the packet version can do the trick?

The model wlmaps has to be changed then accordingly.

See original description
Tags: map

Related branches

lp://staging/~widelands-dev/widelands/elk_moose
Klaus Halfmann: Approve (testing)
Diff: 455 lines (+102/-30)
16 files modified
data/world/critters/moose/init.lua (+2/-2)
data/world/init.lua (+1/-1)
data/world/map_generation.lua (+6/-6)
src/logic/map.cc (+16/-0)
src/logic/map.h (+8/-0)
src/logic/map_objects/world/critter.cc (+3/-2)
src/logic/map_revision.h (+2/-0)
src/map_io/map_bob_packet.cc (+3/-3)
src/map_io/map_bob_packet.h (+1/-1)
src/map_io/map_saver.cc (+1/-1)
src/map_io/map_version_packet.cc (+12/-5)
src/map_io/map_version_packet.h (+17/-2)
src/map_io/widelands_map_loader.cc (+5/-1)
src/map_io/world_legacy_lookup_table.cc (+23/-5)
src/map_io/world_legacy_lookup_table.h (+1/-1)
src/website/map_info.cc (+1/-0)
lp://staging/~widelands-dev/widelands-website/move_maps_minimap
kaputtnik (community): Needs Resubmitting
GunChleoc: Approve
Diff: 247 lines (+124/-22)
7 files modified
wlmaps/admin.py (+13/-1)
wlmaps/forms.py (+15/-6)
wlmaps/migrations/0003_auto_20190712_0928.py (+65/-0)
wlmaps/models.py (+16/-1)
wlmaps/templates/wlmaps/index.html (+3/-7)
wlmaps/templates/wlmaps/inlines/version_info.html (+11/-0)
wlmaps/templates/wlmaps/map_detail.html (+1/-7)
kaputtnik (franku)
description: updated
Revision history for this message
GunChleoc (gunchleoc) wrote :

This is distinct from the amount of players. We changed the name of a map entity and did not bump any packet numbers.

I have another one of those - let me make a merge request and bump the version number there.

tags: added: map
Revision history for this message
kaputtnik (franku) wrote :

Bumping the version number does not change the string on the website.

It would be bad if a player downloads a map (announced for > build19) and after trying to start a game he get an errormessage.

Or do i miss some thing?

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

the map itself is compatible with b20. Only the scripting is not as it uses the ware descriptions changed in bzr9119. So this is a bit misleading. the map and the scripting is the second atl mision to come

Revision history for this message
kaputtnik (franku) wrote :

Thanks for clarification :)

Changed in widelands-website:
status: New → Invalid
Revision history for this message
kaputtnik (franku) wrote :

Hm, maybe there will be some more maps with incompatible scripting on the website. How should we handle that?

Revision history for this message
GunChleoc (gunchleoc) wrote :

We have a scripting packet that is versioned. We could bump the version number.

This can get pretty complicated though to keep compatibility here, because the scripting API still changes all the time.

Revision history for this message
GunChleoc (gunchleoc) wrote :

In the attached branch, I have introduced a map version property "needs_widelands_version_after" for the website. This will of course only work for Maps that write this entry, so you will have to keep the code for older maps as it is.

I decided to go for release versioning only - use development versions at your own risk.

Revision history for this message
GunChleoc (gunchleoc) wrote :

P.S: actually, if you rerun wl_map_info for all maps, the JSON will include the info and you can get rid of handling stuff in the website code.

Revision history for this message
GunChleoc (gunchleoc) wrote :

The Widelands part has just hit trunk.

Changed in widelands:
milestone: none → build21-rc1
Changed in widelands-website:
status: Invalid → Confirmed
Changed in widelands:
status: New → Fix Committed
Revision history for this message
kaputtnik (franku) wrote :

> P.S: actually, if you rerun wl_map_info for all maps, the JSON will include the info and you can get rid of handling stuff in the website code.

Running wl_map_info on old maps produces an error. I think what needs to be done to prevent the error is to resave each map with a recent widelands revision and upload a again. Too much work, imho.

Handling the stuff in the website code isn't problematic, so i did that.

Revision history for this message
GunChleoc (gunchleoc) wrote :

Running wl_map_info should not produce an error, we should fix that.

Changed in widelands:
status: Fix Committed → Confirmed
Revision history for this message
kaputtnik (franku) wrote :

> P.S: actually, if you rerun wl_map_info for all maps, the JSON will include the info and you can get rid of handling stuff in the website code.

As far i understand the info is only added when a map get saved in the editor. So only rerunning wl_map_info is not sufficient.

Revision history for this message
GunChleoc (gunchleoc) wrote :

OK, too much work then.

kaputtnik (franku)
Changed in widelands:
status: Confirmed → Fix Released
status: Fix Released → Confirmed
Changed in widelands-website:
status: Confirmed → Fix Released
GunChleoc (gunchleoc)
Changed in widelands:
status: Confirmed → Fix Committed
Revision history for this message
GunChleoc (gunchleoc) wrote :

Migrated to https://github.com/widelands/widelands/issues/3451

Changed in widelands:
status: Fix Committed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.