Set Focus on inputbox after clicking on player name in lobby
Bug #1827762 reported by
Klaus Halfmann
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Won't Fix
|
Low
|
Unassigned | ||
Bug Description
This is not really bug but quite annoying:
When you clik on a players name in the lobby an @<PlayerName> is inserted in the
chatline, but the focus is still on the List of Players (my assumption).
So if you start typing right away your input is lost.
So you need another click on the inputbox / textarea before you can type.
Thats not intuitive and confuses the avergare user.
Fix: Set focus to input text area after inserting the @<PlayerName>
Related branches
lp://staging/~widelands-dev/widelands/bug-1827182-sort-client-list
- GunChleoc: Approve
-
Diff: 186 lines (+42/-16)6 files modifiedsrc/network/internet_gaming.cc (+10/-11)
src/ui_basic/panel.h (+1/-2)
src/ui_fsmenu/internet_lobby.cc (+12/-3)
src/ui_fsmenu/launch_mpg.cc (+6/-0)
src/wui/game_chat_panel.cc (+12/-0)
src/wui/game_chat_panel.h (+1/-0)
Revision history for this message
| Toni Förster (stonerl) wrote | #1 |
| Changed in widelands: | |
| assignee: | nobody → Toni Förster (stonerl) |
| status: | New → Confirmed |
| status: | Confirmed → In Progress |
Revision history for this message
| Klaus Halfmann (klaus-halfmann) wrote | #2 |
| Changed in widelands: | |
| assignee: | Toni Förster (stonerl) → nobody |
| status: | In Progress → Fix Committed |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #3 |
| Changed in widelands: | |
| status: | Fix Committed → Won't Fix |
To post a comment you must log in.
Klaus can you test the linked branch, please? Also, Gun apparently had a crash with that branch. Can you try to reproduce this?