widelands

AI stocklevel not taken into account for building neededness

Bug #1827279 reported by hessenfarmer
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Won't Fix
Undecided
Unassigned
widelands build21-rc1

Bug Description

the current stocklevel (i.e. shortage of ware) is not taken into account for neeededness of a productionsite building.

I promisingly experimented with the following lines after l5710 in defaultai.cc:

   inputs[107] = std::abs(management_data.get_military_number_at(190)) - get_stocklevel(bo, gametime);
   inputs[108] = std::abs(management_data.get_military_number_at(191)) - get_stocklevel(bo, gametime);

however this stalls again. keep analysing

Tags: ai

Related branches

lp://staging/~widelands-dev/widelands/AI-fixes
Benedikt Straub: Approve
hessenfarmer: Needs Resubmitting
TiborB: Approve
Diff: 411 lines (+73/-48)
11 files modified
data/ai/ai_input_1.wai (+1/-1)
data/ai/ai_input_2.wai (+1/-1)
data/ai/ai_input_3.wai (+1/-1)
data/ai/ai_input_4.wai (+1/-1)
data/tribes/buildings/productionsites/atlanteans/horsefarm/init.lua (+1/-1)
data/tribes/buildings/productionsites/barbarians/barracks/init.lua (+0/-1)
data/tribes/buildings/productionsites/barbarians/cattlefarm/init.lua (+1/-1)
data/tribes/buildings/productionsites/empire/donkeyfarm/init.lua (+1/-1)
data/tribes/wares/coal/init.lua (+4/-4)
src/ai/defaultai.cc (+62/-35)
src/ai/defaultai.h (+0/-1)
Revision history for this message
TiborB (tiborb95) wrote :

I plan resume training soon, so you can just add more such lines and let AI training cope with them...

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

I currently tested these things in a local copy of the fri03 branch to see whether AI is capable of performing the scenario. I made good progress already. However I will prepare a branch over the weekend. I'll be afk of my development machine until Friday evening.

Current behaviour of AI is that it stops building economy after a while, I will investigate.

Furthermore AI doesn't build second carrier recruiting sites (except for frisians where they are build due to the fur output), will investigate that as well, cause we will need them if we really start producing wares

Revision history for this message
TiborB (tiborb95) wrote :

The problem with carriers are that it is hard to measure necessity of its output (no stocklevel of course), but if I remember properly, it is tied to number of buildings but also the building score might be too low...

GunChleoc (gunchleoc)
tags: added: ai
Revision history for this message
hessenfarmer (stephan-lutz) wrote :

I think stocklevel of carriers is available but not taken into account as it is calculated for ware by default, also the code is there to calculate it for workers as well. I'll have look into this for sure, cause currently frisians are favoured by Ai in this particular part.

hessenfarmer (stephan-lutz)
Changed in widelands:
status: New → In Progress
milestone: none → build21-rc1
assignee: nobody → hessenfarmer (stephan-lutz)
hessenfarmer (stephan-lutz)
Changed in widelands:
status: In Progress → Fix Committed
hessenfarmer (stephan-lutz)
Changed in widelands:
assignee: hessenfarmer (stephan-lutz) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Migrated to https://github.com/widelands/widelands/issues/3425

Changed in widelands:
status: Fix Committed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.