OpenStack Designate-Bind Charm

Possible typo: required_relations class variable is defined twice

Bug #1826017 reported by Nikolay Vinogradov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Designate-Bind Charm
Fix Released
Low
Unassigned
OpenStack Designate-Bind Charm 19.04

Bug Description

See class DesignateBindCharm in src/lib/charm/openstack/designate_bind.py line :

...
class DesignateBindCharm(openstack_charm.OpenStackCharm):

    name = 'designate_bind'
    packages = ['bind9', 'apache2']

    services = ['bind9']

    required_relations = ['dns-backend']

    restart_map = {
        '/etc/bind/named.conf.options': services,
        '/etc/bind/named.conf': services,
        '/etc/bind/rndc.key': services,
    }
    service_type = 'designate_bind'
    default_service = 'bind9'
    adapters_class = BindAdapters
    release = 'icehouse'
    required_relations = []
....

Note required_relations being re-defined.

See original description
Nikolay Vinogradov (nikolay.vinogradov)
description: updated
Alex Kavanagh (ajkavanagh)
Changed in charm-designate-bind:
status: New → Confirmed
assignee: nobody → Alex Kavanagh (ajkavanagh)
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-designate-bind (master)

Fix proposed to branch: master
Review: https://review.opendev.org/655225

Changed in charm-designate-bind:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-designate-bind (master)

Reviewed: https://review.opendev.org/655225
Committed: https://git.openstack.org/cgit/openstack/charm-designate-bind/commit/?id=58054337d52496d81c6ffc545f815bd466482642
Submitter: Zuul
Branch: master

commit 58054337d52496d81c6ffc545f815bd466482642
Author: Alex Kavanagh <email address hidden>
Date: Tue Apr 23 19:03:27 2019 +0100

    Remove extraneous first def of required_interfaces

    During a copy/paste two copies of required_interfaces static assignment
    are included in the charm class. The 2nd overrides the first, so this
    commit simply removes the first.

    Change-Id: I5d1622a02db43da01d3b0b7f1ce47a82799bc64a
    Closes-Bug: #1826017

Changed in charm-designate-bind:
status: In Progress → Fix Committed
Ryan Beisner (1chb1n)
Changed in charm-designate-bind:
milestone: none → 19.04
Alex Kavanagh (ajkavanagh)
Changed in charm-designate-bind:
assignee: Alex Kavanagh (ajkavanagh) → nobody
Billy Olsen (billy-olsen)
Changed in charm-designate-bind:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.