widelands

input_queues test will often stall

Bug #1825486 reported by GunChleoc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Won't Fix
High
Unassigned
widelands build21-rc1

Bug Description

We often get this on Travis:

test/maps/plain.wmf/scripting/test_inputqueues.lua ...
  Running Widelands ... done.
  Loading savegame: inputqueues ...
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

We should investigate.

Tags: economy test

Related branches

lp://staging/~widelands-dev/widelands/bug-1825486-inputqueue-test2
Widelands Developers: Pending requested
Diff: 12 lines (+2/-1)
1 file modified
test/maps/plain.wmf/scripting/test_inputqueues.lua (+2/-1)
Revision history for this message
GunChleoc (gunchleoc) wrote :

This seems to be happening mostly on GCC7 debug builds.

Revision history for this message
Benedikt Straub (nordfriese) wrote :

I could now reproduce it once locally: The script worked fine until it was reloaded from the save, then nothing happened. The stopped barracks just stood idling around. I repeated the test to get more output but was unable to reproduce again.

Changed in widelands:
status: New → Confirmed
Revision history for this message
Benedikt Straub (nordfriese) wrote :

Okay, now I could obtain some output from the first half of the test:
…
Script requests save to: inputqueues
# All Tests passed.
Gamesave: save requested: inputqueues
…

It seems like the script completes execution before the actual save happens, so it doesn´t have anything left to do when it´s loaded?
Not sure how to resolve this, just adding some long sleep() after the game:save() in stable_save is not enough…

Revision history for this message
GunChleoc (gunchleoc) wrote :

I have had a look at the save_handler. t saves the game at next tick. If we save immediately, the Lua script should theoretically wait for it. I'll do the coding to see if that fixes it.

Revision history for this message
GunChleoc (gunchleoc) wrote :

Well, that got me "PANIC: unprotected error in call to Lua API". Back to the drawing board...

GunChleoc (gunchleoc)
Changed in widelands:
status: Confirmed → Fix Committed
Revision history for this message
GunChleoc (gunchleoc) wrote :

Migrated to https://github.com/widelands/widelands/issues/586

Changed in widelands:
status: Fix Committed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.