PushButton: allow press-and-hold for Off state, too

Bug #1824682 reported by ronso0
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Wishlist
ronso0

Bug Description

noticed while reading the QuickEffect enable tooltip.
it says "Hold-to-kill or short for latching"

click-and-hold only works for temporarily switching the effect ON.
It would be nice to make it work for the temp. OFF switch as well.

I guess it's easy to fix here
https://github.com/mixxxdj/mixxx/blob/master/src/widget/wpushbutton.cpp#L349
except there's a strong design decision for the current limitation.

Both PushButton & EffectPushButton would benefit from the fix as they act the same right now AFAICT.

Revision history for this message
Daniel Schürmann (daschuer) wrote :

This sounds reasonable.

Changed in mixxx:
status: New → Confirmed
importance: Undecided → Wishlist
ronso0 (ronso0)
Changed in mixxx:
assignee: nobody → ronso0 (ronso0)
status: Confirmed → In Progress
Revision history for this message
ronso0 (ronso0) wrote :
Changed in mixxx:
milestone: none → 2.3.0
Changed in mixxx:
status: In Progress → Fix Committed
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9632

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.