widelands

Savegame menu is not showing multiplayer savegames

Bug #1822437 reported by GunChleoc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Undecided
Unassigned
widelands build20-rc1

Bug Description

To reproduce

1. Start a multiplayer game
2. Save it
2. Open the Save game menu - the game is not listed.

The savegame menu should always list all savegames, no matter if they are single player or multiplayer.

Tags: savegame ui

Related branches

lp://staging/~widelands-dev/widelands/bug-1822437-missing-savegames
hessenfarmer: Approve (test)
Diff: 24 lines (+4/-2)
1 file modified
src/wui/load_or_save_game.cc (+4/-2)
GunChleoc (gunchleoc)
Changed in widelands:
status: New → In Progress
Revision history for this message
hessenfarmer (stephan-lutz) wrote :

But the savegame menu is set below the single player button. while you can setup a new multiplayer from a multiplayer setup so I don't think it is a bug. It has been this way all the time

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

And it is definitly a bigger change so I won't deem it suitable for b20, as it may cause various problems if we change a thing so fundamentally

Revision history for this message
GunChleoc (gunchleoc) wrote :

The savegame menu is accessed from the game that you are currently playing and has nothing whatsoever to do with the singleplayer button. I am not talking about the game loading fullscreen screens here ;)

If you are playing a multiplayer game and want to save it, you don't see the name if the game you are currently playing. Also, maybe you don't want to overwrite a game that's already there, and you can't see it.

This is a regression bug - in Build 19, all games are listed.

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

Ok so I misunderstood this. Sorry for that. I think in this case we should do it

Revision history for this message
GunChleoc (gunchleoc) wrote :

No problem - I guess my description wasn't clear enough.

hessenfarmer (stephan-lutz)
Changed in widelands:
status: In Progress → Fix Committed
assignee: GunChleoc (gunchleoc) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.