Crash loading first track in LateNight with loop points set
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Fix Released
|
Critical
|
Ferran Pujol |
Bug Description
Initial discussion here:
https:/
"What's going on is m_pCurrentTrack is null at construction time. When a track is loaded, some of the signals are crossed so that onMarkChanged is getting called before slotLoadingTrack is called. Therefore, once any track loads correctly, m_pCurrentTrack will never be null again so the crash is avoided. But also, I suspect onMarkChanged is always getting called for the old track, not the current one. onMarkChanged seems to be called by pmark->
"ok so this only occurs on tracks where a loop has been defined. So here are the reproduce instrux:
Start mixxx fresh
Load a track that already has a loop defined
crash
The trigger to the crash is basetrackplayer.cpp where it calls m_pLoopInPoint-
(https:/
"Yes, It only happens with the LateNight skin. All of the other Skins are fine."
Changed in mixxx: | |
status: | New → Confirmed |
importance: | Undecided → Critical |
Changed in mixxx: | |
status: | Fix Committed → Fix Released |
For me, putting a "if (nullptr)" guard around the onMarkChanged handler fixes the problem for me, and the waveform marks are all in the right places so that may be the easiest way to fix it.