ethernet/detect job should be skipped if no Ethernet devices on the testing unit

Bug #1815992 reported by Pierre Equoy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox Provider - Base
Fix Released
High
Jonathan Cave

Bug Description

We are testing a device that has WiFi chip, but no Ethernet controller.

The `ethernet/detect` job is still run[1], with the following output:

----------------------[ Devices found by Network Manager ]----------------------

(in other words, no Network devices are reported)

Since the script launched by the job doesn't crash, the job itself is marked as passed. The problem is that later jobs that depend on ethernet/detect may fail whereas they should simply be skipped. For instance, `network_before_suspend`.

There is for sure an issue, but I'm not sure which one:

1. If the purpose of ethernet/detect is, as said by its description, to "detect and return information about available network controllers", then it should report not only about Ethernet, but also about WiFi controllers. It is not currently the case (I tried on two different devices and in both cases, only Ethernet controllers are reported)
2. If the purpose of this job is only to detect Ethernet controllers, then I think we should add:

    requires:
     device.category == 'NETWORK'

to its definition.

[1] https://certification.canonical.com/hardware/201812-26756/submission/138730/test-results/?term=ethernet

Related branches

Jerry Kao (jerry.kao)
Changed in plainbox-provider-checkbox:
importance: Undecided → High
assignee: nobody → Sylvain Pineau (sylvain-pineau)
tags: added: ce-qa-concern
Revision history for this message
Jonathan Cave (jocave) wrote :

My approach to this would be to make two changes:

1) add a manifest entry so that it can be indicated to checkbox that an adapter should be present
2) have the job fail if zero adapters are found

I think this follows the general pattern of our other detect jobs.

Changed in plainbox-provider-checkbox:
assignee: Sylvain Pineau (sylvain-pineau) → Jonathan Cave (jocave)
Jonathan Cave (jocave)
Changed in plainbox-provider-checkbox:
status: New → In Progress
Jonathan Cave (jocave)
Changed in plainbox-provider-checkbox:
milestone: none → 0.48.0
Changed in plainbox-provider-checkbox:
status: In Progress → Fix Committed
Jonathan Cave (jocave)
Changed in plainbox-provider-checkbox:
status: Fix Committed → Fix Released
Jonathan Cave (jocave)
Changed in plainbox-provider-checkbox:
status: Fix Released → Fix Committed
Revision history for this message
Betty Lin (bettyl) wrote :

Verified that Ethernet adapter added in manifest.
If the answer for Ethernet adapter was no, the ethernet/detect job were skipped.

checkbox-ng: 1.4.0rc1
checkbox-support: 0.41.0rc1
com.canonical.ce:oem: 1.0
certification-client: 0.37.0rc1
plainbox-provider-checkbox: 0.48.0rc3
plainbox-provider-resource-generic: 0.40.0rc1
plainbox-provider-sru: 1.13.0rc1
plainbox-provider-tpm2: 1.10.0rc1

tags: added: cqa-verified
Changed in plainbox-provider-checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.