[2.5] Pod console_logging should be the default (and needs a doc fix)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
High
|
Newell Jensen | ||
2.5 |
Fix Released
|
High
|
Newell Jensen |
Bug Description
When we run into issues with MAAS and pods in a production environment, it's often difficult to determine what went wrong due to the lack of console logging.
In MAAS 2.5, we introduced the ability to update console_
* It is not the default option. Therefore, anyone who has problems in the field will need to recompose any VMs after setting this option, which makes pod VMs difficult to support.
* There is a mistake in the documentation; it states "console_log" instead of "console_logging" as the name of the parameter to use.
Assumming we fix the first problem (lack of console_logging being the default option), the documentation will need to be updated anyway to reflect the new default. So we should fix both of these issues at the same time.
See also -
Original bug:
https:/
Original fix:
https:/
Examples of difficult-to-debug issues to to the lack of this option being the default:
https:/
https:/
Related branches
- MAAS Lander: Approve
- Newell Jensen (community): Approve
-
Diff: 230 lines (+16/-144)3 files modifiedsrc/maasserver/api/tests/test_pods.py (+2/-100)
src/maasserver/forms/pods.py (+9/-42)
src/maasserver/forms/tests/test_pods.py (+5/-2)
- Mike Pontillo (community): Approve
- MAAS Lander: Needs Fixing
-
Diff: 230 lines (+16/-144)3 files modifiedsrc/maasserver/api/tests/test_pods.py (+2/-100)
src/maasserver/forms/pods.py (+9/-42)
src/maasserver/forms/tests/test_pods.py (+5/-2)
Changed in maas: | |
assignee: | Ed Newell (newell) → nobody |
assignee: | nobody → Newell Jensen (newell-jensen) |
milestone: | none → 2.6.0 |
Changed in maas: | |
status: | Triaged → In Progress |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
milestone: | 2.6.0 → 2.6.0alpha1 |
Changed in maas: | |
status: | Fix Committed → Fix Released |
I think the default should be defined in a global option and not something that is just always on. I agree with the reason for it to be on, and with CI systems the global option can be set so the information can be gathered.