kolla

Bifrost container deploy broken by dumb-init ENTRYPOINT

Bug #1808326 reported by Mark Goddard on 2018-12-13

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
kolla	Fix Released	High	Mark Goddard	kolla 8.0.0 "Stein"
Rocky	Fix Released	High	Mark Goddard
Stein	Fix Released	High	Mark Goddard	kolla 8.0.0 "Stein"

Bug Description

Bifrost was broken by the recent kolla change [1] to use an ENTRYPOINT for dumb-init. The container failed to start because dumb-init was trying to run /sbin/init, which expects to be pid 1.

As seen in kayobe CI, the container keeps restarting:

REPOSITORY TAG IMAGE ID CREATED SIZE
kolla/centos-source-bifrost-deploy rocky 8ee6ae4c7e84 3 hours ago 1.724 GB
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
f1f89d0978ca kolla/centos-source-bifrost-deploy:rocky "dumb-init --single-c" 12 seconds ago Restarting (1) 4 seconds ago bifrost_deploy

[1] https://review.openstack.org/612887

Tags:

Mark Goddard (mgoddard) on 2018-12-13

Changed in kolla:
importance:	Undecided → High
assignee:	nobody → Mark Goddard (mgoddard)

Revision history for this message

Mark Goddard (mgoddard) wrote on 2018-12-13:

Affects stable/rocky. Queens patch for dumb-init entrypoint has not yet merged, so that branch is not affected.

Revision history for this message

Mark Goddard (mgoddard) wrote on 2018-12-13:

Queens patch in question, blocked on this: https://review.openstack.org/#/c/621709/2

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-12-13: Change abandoned on kolla (master)

Change abandoned by Rabi Mishra (<email address hidden>) on branch: master
Review: https://review.openstack.org/624978
Reason: OK good, the comment in that patch did not mention that.

Revision history for this message

Mark Goddard (mgoddard) wrote on 2018-12-13:

Fix proposed to master: https://review.openstack.org/#/c/624967

OpenStack Infra (hudson-openstack) on 2018-12-13

Changed in kolla:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-12-18: Fix merged to kolla (master)

Reviewed: https://review.openstack.org/624967
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=6258a920fdf8432f39696815765f3320afe92fca
Submitter: Zuul
Branch: master

commit 6258a920fdf8432f39696815765f3320afe92fca
Author: Mark Goddard <email address hidden>
Date: Thu Dec 13 12:07:59 2018 +0000

Clear ENTRYPOINT configuration for Bifrost

    Bifrost was broken by the recent kolla change [1] to use an ENTRYPOINT
    for dumb-init. The container failed to start because dumb-init was
    trying to run /sbin/init, which expects to be pid 1.

[1] Id91ebb8b0ecc43946845de386350af0536dd661f

    Change-Id: Id77ecfca09dfda8da984589f70a26433214ee3af
    Closes-Bug: #1808326
    Related-Bug: #1799642

Changed in kolla:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-12-18: Fix proposed to kolla (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/625930

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-12-18: Fix merged to kolla (stable/rocky)

Reviewed: https://review.openstack.org/625930
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=fe7ff62f68689362799cc9147cd456dd633255fe
Submitter: Zuul
Branch: stable/rocky

commit fe7ff62f68689362799cc9147cd456dd633255fe
Author: Mark Goddard <email address hidden>
Date: Thu Dec 13 12:07:59 2018 +0000

Clear ENTRYPOINT configuration for Bifrost

    Bifrost was broken by the recent kolla change [1] to use an ENTRYPOINT
    for dumb-init. The container failed to start because dumb-init was
    trying to run /sbin/init, which expects to be pid 1.

[1] Id91ebb8b0ecc43946845de386350af0536dd661f

    Change-Id: Id77ecfca09dfda8da984589f70a26433214ee3af
    Closes-Bug: #1808326
    Related-Bug: #1799642
    (cherry picked from commit 6258a920fdf8432f39696815765f3320afe92fca)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-12-19: Fix merged to kolla (stable/queens)

Reviewed: https://review.openstack.org/621709
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=1dacd1944e285ef70f60c7e9982fa2ab180b144e
Submitter: Zuul
Branch: stable/queens

commit 1dacd1944e285ef70f60c7e9982fa2ab180b144e
Author: Rabi Mishra <email address hidden>
Date: Wed Oct 24 11:24:07 2018 +0530

Use dumb-init with --single-child

    We would probably like to forward signals only to the direct child
    which in turn takes care its children and not to all worker child
    processes.

(cherry picked from commit 6258a920fdf8432f39696815765f3320afe92fca)

This change also includes a cherry pick of a fix for bifrost:

Clear ENTRYPOINT configuration for Bifrost

    Bifrost was broken by the recent kolla change [1] to use an ENTRYPOINT
    for dumb-init. The container failed to start because dumb-init was
    trying to run /sbin/init, which expects to be pid 1.

[1] Id91ebb8b0ecc43946845de386350af0536dd661f

(cherry picked from commit b06d8387f50ac9c536941ffddb00c5bdb45753b6)

    Change-Id: Id91ebb8b0ecc43946845de386350af0536dd661f
    Depends-On: https://review.openstack.org/621871/
    Closes-Bug: #1808326
    Related-Bug: #1799642
    Related-Bug: #1799642