Crash when burning enemies military sites

Bug #1805508 reported by Notabilis
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Undecided
Unassigned

Bug Description

When a medium military building is conquered, small military buildings very close to it burn down without a fight.
When multiple small military buildings are burned down at once, the game crashes due to a failed assertion (when releasing the area of the small sites):

 assert(preferred_player != player_area.player_number); (logic/editor_game_base.cc line 663).

The simplest fix seems to be to remove the assert(). It doesn't seems to be required for the correct functioning of the method and after removing it the game seems to work fine.
The linked branch applies this "fix". I haven't created a merge request yet since I am unsure whether we really want to fix it that way, but feel free to do so.

Tags: crash military

Related branches

Revision history for this message
GunChleoc (gunchleoc) wrote :

Multiplayer savegame to reproduce. Play as red player and attack the Barrier.

Changed in widelands:
milestone: none → build20-rc1
status: New → Confirmed
tags: added: crash military
GunChleoc (gunchleoc)
Changed in widelands:
status: Confirmed → In Progress
GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.