Mistral

Mistral doesn't send TASK_FAILED event in case of MistralException

Bug #1803746 reported by Oleg Ovcharuk
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
High
Oleg Ovcharuk
Mistral stein-3

Bug Description

In task_handler, there are a lot of functions which handle MistralException. They set task's state to ERROR and force fail workflow.

In this cases, actual event chain is:
WORKFLOW_LAUNCHED -> TASK_LAUNCHED -> WORKFLOW_FAILED

But the expected result is:
WORKFLOW_LAUNCHED -> TASK_LAUNCHED -> TASK_FAILED -> WORKFLOW_FAILED

This behavior obstruct to perform some rollback mechanisms, and so on.

Dougal Matthews (d0ugal)
Changed in mistral:
status: New → Confirmed
importance: Undecided → High
Renat Akhmerov (rakhmerov)
Changed in mistral:
milestone: none → stein-2
assignee: nobody → Oleg Ovcharuk (vgvoleg)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (master)

Fix proposed to branch: master
Review: https://review.openstack.org/619192

Changed in mistral:
status: Confirmed → In Progress
Renat Akhmerov (rakhmerov)
Changed in mistral:
milestone: stein-2 → stein-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/619192
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=87200f6aea54eb4f47146f6bebd502c8c8fe9dbc
Submitter: Zuul
Branch: master

commit 87200f6aea54eb4f47146f6bebd502c8c8fe9dbc
Author: Oleg Ovcharuk <email address hidden>
Date: Wed Nov 21 12:59:45 2018 +0300

    Sending TASK_FAILED event in case of MistralException

    If task was failed by unhandled exceptions, Mistral was not sending
    TASK_FAILED event, which could be critical for Mistral's clients, who
    use notifications mechanism to handle issues.

    Change-Id: I460686c2852e3eb642506049ad5c33705697ecd8
    Closes-Bug: #1803746
    Signed-off-by: Oleg Ovcharuk <email address hidden>

Changed in mistral:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 8.0.0.0b2

This issue was fixed in the openstack/mistral 8.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.