Use of vaultlocker based block device encryption requires use of PPA

Please include more details about how you intend to consume and configure this. A sanitized bundle would be best in describing that. Also, a more complete juju unit log from the existing failure would be helpful. Thank you.

The best way would be to add an origin option to specify a deb line
with a pipe and the key for the repository in the bundle, like:

    options:
      origin: |
        deb http://mydomain.com/openstack-charmers/vaultlocker/ubuntu/ xenial main
        |
        -----BEGIN PGP PUBLIC KEY BLOCK-----

        ...
        -----END PGP PUBLIC KEY BLOCK-----

For reference:

https://github.com/openstack/charm-ceph-osd/blob/17c64df68145edc2bf8f3023a09dad6c63c222f2/hooks/ceph_hooks.py#L404-L413

Rather than implement a new feature via escalation as a bespoke source/origin option for the vaultlocker package, we need to solve vaultlocker's current distribution challenge.

We will do that by releasing vaultlocker in the Queens and Rocky Ubuntu Cloud Archives.

It will then be consumable via offline repos along with the rest of the cloud archive which is already being mirrored offline in the use cases behind this bug.

vaultlocker and hvac have been accepted into bionic-backports and are in the xenial/queens-proposed UCA pocket.

As soon as that is all built and published we can drop the need for the PPA addition from vaultlocker from all three charms - I'll raise the reviews for that now.

Fix proposed to branch: master
Review: https://review.openstack.org/617608

Charm reviews up however they can't land until pkgs are in UCA/updates and bionic-backports.

  https://review.openstack.org/#/q/topic:bug/1802905+(status:open+OR+status:merged)

I'll post the charms on the charmstore as well so UCA/queens-proposed can be used as a interim workaround

Charms to use until vaultlocker is generally available:

cs:~james-page/nova-compute-38
cs:~james-page/swift-storage-22
cs:~james-page/ceph-osd-96

Please use the specific versions.

vaultlocker is in xenial-queens/updates; I'm just waiting for the backport in bionic to be accepted.

Change abandoned by James Page (<email address hidden>) on branch: master
Review: https://review.openstack.org/617367
Reason: vaultlocker is in all the right places now so no need for this review.

vaultlocker is also now in bionic-backports

Reviewed: https://review.openstack.org/617608
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-osd/commit/?id=3136669653d1bc1a41571cd6e4a4fc02d6f9d807
Submitter: Zuul
Branch: master

commit 3136669653d1bc1a41571cd6e4a4fc02d6f9d807
Author: James Page <email address hidden>
Date: Tue Nov 13 11:36:46 2018 +0000

    Drop use of vaultlocker PPA

    vaultlocker is now provided in the UCA and via backports in bionic.

    Change-Id: I257b1b2e8aff7900eb0845ea416b54fb42b6b1f5
    Closes-Bug: 1802905

Reviewed: https://review.openstack.org/617611
Committed: https://git.openstack.org/cgit/openstack/charm-swift-storage/commit/?id=9dfe75d82efb4f1d541cee8c667be94dc31d9f85
Submitter: Zuul
Branch: master

commit 9dfe75d82efb4f1d541cee8c667be94dc31d9f85
Author: James Page <email address hidden>
Date: Tue Nov 13 11:41:06 2018 +0000

    Drop use of vaultlocker PPA

    vaultlocker is now provided in the UCA and in backports for bionic.

    Change-Id: Ia2b4cfe75a152d4d8e1de7cda076b692ebd9d398
    Closes-Bug: 1802905

Reviewed: https://review.openstack.org/617610
Committed: https://git.openstack.org/cgit/openstack/charm-nova-compute/commit/?id=c68107f4be0a5939c0980b51b2ba4ac58453642e
Submitter: Zuul
Branch: master

commit c68107f4be0a5939c0980b51b2ba4ac58453642e
Author: James Page <email address hidden>
Date: Tue Nov 13 11:39:31 2018 +0000

    Drop use of vaultlocker PPA

    vaultlocker is now provided in the UCA and in backports for bionic.

    Change-Id: Iedff261d08401e99eb4e9f913458648d13fff048
    Closes-Bug: 1802905

Fix proposed to branch: stable/18.11
Review: https://review.openstack.org/621581

Fix proposed to branch: stable/18.11
Review: https://review.openstack.org/621582

Fix proposed to branch: stable/18.11
Review: https://review.openstack.org/621583

Reviewed: https://review.openstack.org/621582
Committed: https://git.openstack.org/cgit/openstack/charm-swift-storage/commit/?id=63b5037662c4ee9f93c81f71c5686ecea2741c17
Submitter: Zuul
Branch: stable/18.11

commit 63b5037662c4ee9f93c81f71c5686ecea2741c17
Author: James Page <email address hidden>
Date: Tue Nov 13 11:41:06 2018 +0000

    Drop use of vaultlocker PPA

    vaultlocker is now provided in the UCA and in backports for bionic.

    Change-Id: Ia2b4cfe75a152d4d8e1de7cda076b692ebd9d398
    Closes-Bug: 1802905
    (cherry picked from commit 9dfe75d82efb4f1d541cee8c667be94dc31d9f85)

Reviewed: https://review.openstack.org/621583
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-osd/commit/?id=e369a0973d397fb1df19b0b8d0cf7b548f090a43
Submitter: Zuul
Branch: stable/18.11

commit e369a0973d397fb1df19b0b8d0cf7b548f090a43
Author: James Page <email address hidden>
Date: Tue Nov 13 11:36:46 2018 +0000

    Drop use of vaultlocker PPA

    vaultlocker is now provided in the UCA and via backports in bionic.

    Change-Id: I257b1b2e8aff7900eb0845ea416b54fb42b6b1f5
    Closes-Bug: 1802905
    (cherry picked from commit 3136669653d1bc1a41571cd6e4a4fc02d6f9d807)

Reviewed: https://review.openstack.org/621581
Committed: https://git.openstack.org/cgit/openstack/charm-nova-compute/commit/?id=a0d3a955dd131effd449e3982590b0ab4cfeac81
Submitter: Zuul
Branch: stable/18.11

commit a0d3a955dd131effd449e3982590b0ab4cfeac81
Author: James Page <email address hidden>
Date: Tue Nov 13 11:39:31 2018 +0000

    Drop use of vaultlocker PPA

    vaultlocker is now provided in the UCA and in backports for bionic.

    Change-Id: Iedff261d08401e99eb4e9f913458648d13fff048
    Closes-Bug: 1802905
    (cherry picked from commit c68107f4be0a5939c0980b51b2ba4ac58453642e)