Repetitive code block in vm-do-reply?

This is not a high priority right now.

It seems that the second copy of the code block is covering up the error in the first code block.

If you are replying to a message with a "reply-to" header, then the first code block adds it to 'to' and the second code block becomes a no-op.

If you are reply to a message without a "reply-to" header, then the first code block adds a nil to 'to' and the second code block adds the "from" header. (If the first code block had done the job, then this would become a no-op as well.)

The spurious nil is then eliminated by vm-parse-addresses later on.

What confusion!

I'll fix this together with bug 544898.

This should be fixed in r803 of the trunk. I haven't done extensive tests though.

For reference, adding some info from my e-mail message of 2010-03-24:

"[...] the first cond is strange, since add-to-list can never evaluate to nil: even if both the list-variable and the element are nil, then add-to-list will still return "(nil)" which is non-nil (i.e. it doesn't return the empty list, but a list with one element that is nil). So the first condition will always be true, and the remaining conditions cannot be reached."

I have eliminated these "add-to-list" conditions now.