OpenStack Keystone Charm

Apache PIDs should be monitored more precisely on restart

Bug #1795918 reported by Andrey Grebennikov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Ceilometer Charm
Triaged
High
Unassigned
OpenStack Cinder Charm
Triaged
High
Unassigned
OpenStack Keystone Charm
Fix Released
High
Andrey Grebennikov
OpenStack Keystone Charm 18.11
OpenStack Nova Cloud Controller Charm
Triaged
High
Unassigned

Bug Description

When config-changed hooks are running, the way keystone-charm monitors that Apache has been restarted is to execute "pgrep apache2".

In case the bundle defines Keystone on the host and any other service running under Apache inside LXD container - the command will always return PIDs of all Apache processes running on the host, consequently juju agent will be waiting for all them to be restarted.
Instead of "pgrep apache2" it should be executing "pgrep -f keystone", which only returns Keystone-related PIDs.

Andrey Grebennikov (agrebennikov)
Changed in charm-keystone:
assignee: nobody → Andrey Grebennikov (agrebennikov)
Dmitrii Shcherbakov (dmitriis)
Changed in charm-keystone:
status: New → Triaged
importance: Undecided → High
milestone: none → 18.11
Revision history for this message
Ryan Beisner (1chb1n) wrote :

We should look at all os-charms and evaluate for this impact.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/608346

Changed in charm-keystone:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-keystone (master)

Reviewed: https://review.openstack.org/608346
Committed: https://git.openstack.org/cgit/openstack/charm-keystone/commit/?id=f0ee6692792a7a2ad7dafa7f9914251b9ba4f338
Submitter: Zuul
Branch: master

commit f0ee6692792a7a2ad7dafa7f9914251b9ba4f338
Author: Andrey Grebennikov <email address hidden>
Date: Fri Oct 5 14:51:59 2018 -0500

    Improve Apache PID check on service restart

    In case there are containers with Apache running on the same
    host, the charm will only watch PIDs within the same namespace.

    Change-Id: I9cdd7d5b1f53fce748e7fafab538676e4e55dd54
    Closes-Bug: #1795918

Changed in charm-keystone:
status: In Progress → Fix Committed
David Ames (thedac)
Changed in charm-keystone:
status: Fix Committed → Fix Released
Revision history for this message
Corey Bryant (corey.bryant) wrote :

I've targeted some of the charms that I know are affected by this bug, but this bug needs a full audit of charms to determine which ones are definitely affected.

Changed in charm-cinder:
status: New → Triaged
importance: Undecided → High
Changed in charm-ceilometer:
status: New → Triaged
importance: Undecided → High
Changed in charm-nova-cloud-controller:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Aurelien Lourot (aurelien-lourot) wrote :

Maybe related to lp:1952414

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-ceilometer (master)

Change abandoned by "Billy Olsen <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/charm-ceilometer/+/639631
Reason: Change has not been updated to address feedback in > 180 days

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-cinder (master)

Change abandoned by "Billy Olsen <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/charm-cinder/+/641003
Reason: Change has not been updated to address feedback in > 180 days

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-keystone (master)

Change abandoned by "Alex Kavanagh <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/charm-keystone/+/641043
Reason: Although it seems a reasonable change, it appears this has been also fixed via https://review.opendev.org/c/openstack/charm-keystone/+/608346, but also this change has charm-helper's changes that aren't in the charm-helper's library (there may be a PR for them). If this is still current, then please re-open the change, add a link to the charm-helpers PR (and cross link that PR back to this gerrit review) and then we can see to getting it landed. Thanks.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.