widelands

Building windows too easy to minimize (Ctrl-click)

Bug #1792774 reported by Benedikt Straub
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
widelands
Won't Fix
Undecided
Unassigned
widelands build21-rc1

Bug Description

Ctrl-clicking a window minimizes it so only the title bar is shown. The ware priority buttons are very small, so when Ctrl-clicking them it is easy to miss them by a pixel and accidentally minimize the window, which is annoying.
I propose to either enlarge the ware priority buttons significantly, or permit the minimizing of a window with Ctrl-click only if the mouse pointer is in the window´s title bar (middle mouse click could be left unchanged, as it has no other function), or both.

Tags: ui

Related branches

lp://staging/~widelands-dev/widelands/bug-1791891-key-modifier-inputqueue
GunChleoc: Approve
Benedikt Straub: Approve (code)
Diff: 167 lines (+74/-16)
2 files modified
src/wui/inputqueuedisplay.cc (+72/-15)
src/wui/inputqueuedisplay.h (+2/-1)
lp://staging/~widelands-dev/widelands/ctrl-priorities
GunChleoc: Approve
Diff: 91 lines (+47/-2)
3 files modified
data/txts/tips/general_game.lua (+2/-2)
src/wui/inputqueuedisplay.cc (+43/-0)
src/wui/inputqueuedisplay.h (+2/-0)
Revision history for this message
hessenfarmer (stephan-lutz) wrote :

As the branch for CTRL-CLicking the ware priority buttons I won't consider this a bug more a development review comment to be fixed for the relevant branch. so at least we should link this to the new branch

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

Why not use another key like "Shift" that is not used currently?

Revision history for this message
Notabilis (notabilis27) wrote :

The bug report is actually about the priority buttons, not about the new branch with the amount buttons. But it affects the new branch as well.
I decided to use Ctrl back when the "set all priorities" feature was implemented since it is kind like a "strong" order to set the priority, similar to the function of, e.g., the "Dismantle" button.

Modifying the "minimize" function to only work when clicked on the window title should be as easy as adding
    && my < VT_B_PIXMAP_THICKNESS
to the condition within Window::handle_mousepress() (not tested).
I would like that change since it is (more or less) similar to the behavior of the windows of the operating system.

Revision history for this message
GunChleoc (gunchleoc) wrote :

+1 for #3

GunChleoc (gunchleoc)
Changed in widelands:
milestone: none → build21-rc1
status: New → Fix Committed
Revision history for this message
Benedikt Straub (nordfriese) wrote :

Unless I´m confusing stuff here, this was assigned to that branch by mistake and the issue is still unsolved

Changed in widelands:
status: Fix Committed → Confirmed
Revision history for this message
GunChleoc (gunchleoc) wrote :

Migrated to https://github.com/widelands/widelands/issues/3320

Changed in widelands:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.