widelands

Some Tribe immovables have no owner

Bug #1790804 reported by GunChleoc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Undecided
Unassigned
widelands build20-rc1

Bug Description

When writing a savegame, there's a bunch of messages:

Writing Map Objects ... Tribe immovable 'berry_bush_desert_hackberry_ripe' has no owner!!

This only happens with the Frisian berry bushes.

Related branches

lp://staging/~widelands-dev/widelands/immovable-grow-owner
GunChleoc: Approve
Diff: 15 lines (+2/-1)
1 file modified
src/logic/map_objects/immovable.cc (+2/-1)
lp://staging/~widelands-dev/widelands/geologist-messages
hessenfarmer: Approve
GunChleoc: Needs Fixing
Diff: 208 lines (+14/-14)
2 files modified
data/tribes/immovables/resi/frisians/init.lua (+11/-11)
src/logic/map_objects/tribes/worker.cc (+3/-3)
Revision history for this message
Benedikt Straub (nordfriese) wrote :

I also get these messages for resource indicators sometimes. Perhaps this happens when a tribe immovable is not on any player´s territory?

Changed in widelands:
status: New → Confirmed
Revision history for this message
Benedikt Straub (nordfriese) wrote :

Btw, I just saw that resource indicators are created explicitly with nullptr as owner, no reason given (Worker::run_findresources). Don´t know why bushes also have no owner, they do get an owner on plant and transform…

Revision history for this message
GunChleoc (gunchleoc) wrote :

for the resource indicators, maybe an owner was imply not considered necessary, because they had the same files for all tribes. Also, they were a shared entity in the old implementation before we merged the tribes, so it's probably just a relic. They can have an owner now.

Revision history for this message
Benedikt Straub (nordfriese) wrote :

For resis, this is fixed in the geologist-messages branch.
The cause for the bushes is in the "grow" program for immovables (logic/map_objects/immovables.cc:933). nullptr is set as owner when something grows into a larger version of itself.

Benedikt Straub (nordfriese)
Changed in widelands:
assignee: nobody → Benedikt Straub (nordfriese)
status: Confirmed → In Progress
Benedikt Straub (nordfriese)
Changed in widelands:
assignee: Benedikt Straub (nordfriese) → nobody
status: In Progress → Fix Committed
GunChleoc (gunchleoc)
summary: - Frisian berry bushes have no owner
+ Some Tribe immovables have no owner
Changed in widelands:
status: Fix Committed → In Progress
GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.