Using --local-push-destination for openstack tripleo container image prepare command leads to undercloud failures

Bug #1786521 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Critical
Steve Baker

Bug Description

If you run...
openstack tripleo container image prepare default \
          --output-env-file /home/stack/containers-prepare-parameter.yaml \
          --local-push-destination

The containers-prepare-parameter.yaml has a push_destination: true in it. This leads to the following failure when you run 'openstack undercloud install'

templates/./puppet/services/haproxy-internal-tls-certmonger.yaml
jinja2 rendering normal template docker-registry.j2.yaml
rendering j2 template to file: /home/stack/tripleo-heat-installer-templates/./puppet/services/docker-registry.yaml
Exception: sequence item 0: expected string, bool found
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/tripleoclient/v1/tripleo_deploy.py", line 1033, in _standalone_deploy
    parsed_args)
  File "/usr/lib/python2.7/site-packages/tripleoclient/v1/tripleo_deploy.py", line 651, in _deploy_tripleo_heat_templates
    self._prepare_container_images(env, parsed_args)
  File "/usr/lib/python2.7/site-packages/tripleoclient/v1/tripleo_deploy.py", line 629, in _prepare_container_images
    env, roles_data, dry_run=True)
  File "/usr/lib/python2.7/site-packages/tripleo_common/image/kolla_builder.py", line 154, in container_images_prepare_multi
    modify_vars=modify_vars,
  File "/usr/lib/python2.7/site-packages/tripleo_common/image/kolla_builder.py", line 271, in container_images_prepare
    imagename = '/'.join((push_destination, image))
TypeError: sequence item 0: expected string, bool found
None
Install artifact is located at /home/stack/undercloud-install-20180810110859.tar.bzip2

Tags: containers
Changed in tripleo:
assignee: nobody → Steve Baker (steve-stevebaker)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/591257

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/591257
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=5ba17936fb457e2bdababb83471e428d7287f49e
Submitter: Zuul
Branch: master

commit 5ba17936fb457e2bdababb83471e428d7287f49e
Author: Bogdan Dobrelya <email address hidden>
Date: Fri Aug 10 17:12:55 2018 +0200

    Support push_destination:true in prepare

    The fix for bug #1783204 only handled the upload logic in isolation,
    and didn't account for the whole prepare flow. This change completes
    push_destination:true support with the following changes:
    - container_images_prepare_multi, which is the heat parameter driven
      interface for prepare, use heat parameter LocalContainerRegistry as
      the registry IP, which is only set during undercloud install. This
      handles the case where registry discovery won't work because it is too
      early in the undercloud install process
    - container_images_prepare, which is the python library API for
      prepare, make the image registry substitution support
      push_destination:true. The discovery logic can be used here since
      this is only ever called after networking is configured on the
      undercloud

    Change-Id: Ia18c89a48ef0fd0f3021823c6049042ac5e78eb8
    Related-Bug: #1783204
    Closes-Bug: #1786521

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 9.3.0

This issue was fixed in the openstack/tripleo-common 9.3.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.