ovb image build broken due to diskimage_builder.element_dependencies.MissingElementException: Element 'disable-nouveau' not found

Fix proposed to branch: master
Review: https://review.openstack.org/586591

Related fix proposed to branch: master
Review: https://review.openstack.org/586595

Reviewed: https://review.openstack.org/586591
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=28384614a52b0b75fc2fcd40103ec6cfd3d86a69
Submitter: Zuul
Branch: master

commit 28384614a52b0b75fc2fcd40103ec6cfd3d86a69
Author: Alex Schultz <email address hidden>
Date: Fri Jul 27 14:56:14 2018 +0000

    Revert "Add disable-nouveau element to tripleo images"

    This reverts commit 7c396455739209e102ea2409e557373f9c5afd9c.

    Without a promoted DIB package, this causes OVB jobs to fail.

    Change-Id: I8bacdf2811bfbe95010360cf4e99879ae1f313b2
    Closes-Bug: #1784015

Reviewed: https://review.openstack.org/586595
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=2af9c11f08f3437284ca9f1bdca7c86dd79176cb
Submitter: Zuul
Branch: master

commit 2af9c11f08f3437284ca9f1bdca7c86dd79176cb
Author: Alex Schultz <email address hidden>
Date: Fri Jul 27 08:57:34 2018 -0600

    Revert "Revert "Add disable-nouveau element to tripleo images""

    This reverts commit 28384614a52b0b75fc2fcd40103ec6cfd3d86a69.

    This should land after we have a promoted DIB.

    Change-Id: I1ae04d297bdd81f2ecfef8e2dc5a650cae9616ad
    Related-Bug: #1784015

This issue was fixed in the openstack/tripleo-common 9.3.0 release.

It looks like the issue is still there. I faced it deploying rocky. I used the official CentOS-OpenStack-rocky.repo

openstack-tripleo-common-9.3.0-1.el7.noarch.rpm (http://mirror.centos.org/centos/7/cloud/x86_64/openstack-rocky/)

(undercloud) [stack@undercloud ~]$ openstack overcloud image build
Running ['disk-image-create', '-a', 'amd64', '-o', './overcloud-full', '-t', 'qcow2', '-p', 'python-psutil,python-debtcollector,plotnetcfg,sos,ntp,device-mapper-multipath,openstack-heat-agents,os-net-config,jq,dbus-python,yum-plugin-priorities', '--min-tmpfs=7', '--mkfs-options', '-s size=4096', 'centos7', 'baremetal', 'dhcp-all-interfaces', 'openvswitch', 'overcloud-agent', 'overcloud-full', 'overcloud-controller', 'overcloud-compute', 'overcloud-ceph-storage', 'puppet-modules', 'stable-interface-names', 'grub2', 'element-manifest', 'dynamic-login', 'iptables', 'enable-packages-install', 'pip-and-virtualenv-override', 'dracut-regenerate', 'remove-machine-id', 'remove-resolvconf', 'openssh', 'disable-nouveau', 'selinux-permissive']
Logging output to ./overcloud-full.log
2018-09-22 12:20:06.633 | diskimage-builder version 2.16.0
2018-09-22 12:20:06.635 | Building elements: base centos7 baremetal dhcp-all-interfaces openvswitch overcloud-agent overcloud-full overcloud-controller overcloud-compute overcloud-ceph-storage puppet-modules stable-interface-names grub2 element-manifest dynamic-login iptables enable-packages-install pip-and-virtualenv-override dracut-regenerate remove-machine-id remove-resolvconf openssh disable-nouveau selinux-permissive
2018-09-22 12:20:06.790 | Traceback (most recent call last):
2018-09-22 12:20:06.790 | File "/bin/element-info", line 10, in <module>
2018-09-22 12:20:06.790 | sys.exit(main())
2018-09-22 12:20:06.790 | File "/usr/lib/python2.7/site-packages/diskimage_builder/element_dependencies.py", line 342, in main
2018-09-22 12:20:06.791 | elements = _get_elements(args.elements)
2018-09-22 12:20:06.791 | File "/usr/lib/python2.7/site-packages/diskimage_builder/element_dependencies.py", line 253, in _get_elements
2018-09-22 12:20:06.791 | return _expand_element_dependencies(elements, all_elements)
2018-09-22 12:20:06.791 | File "/usr/lib/python2.7/site-packages/diskimage_builder/element_dependencies.py", line 148, in _expand_element_dependencies
2018-09-22 12:20:06.791 | raise MissingElementException("Element '%s' not found" % element)
2018-09-22 12:20:06.791 | diskimage_builder.element_dependencies.MissingElementException: Element 'disable-nouveau' not found
Command '['disk-image-create', '-a', 'amd64', '-o', './overcloud-full', '-t', 'qcow2', '-p', 'python-psutil,python-debtcollector,plotnetcfg,sos,ntp,device-mapper-multipath,openstack-heat-agents,os-net-config,jq,dbus-python,yum-plugin-priorities', '--min-tmpfs=7', '--mkfs-options', '-s size=4096', 'centos7', 'baremetal', 'dhcp-all-interfaces', 'openvswitch', 'overcloud-agent', 'overcloud-full', 'overcloud-controller', 'overcloud-compute', 'overcloud-ceph-storage', 'puppet-modules', 'stable-interface-names', 'grub2', 'element-manifest', 'dynamic-login', 'iptables', 'enable-packages-install', 'pip-and-virtualenv-override', 'dracut-regenerate', '...

That's likely related to an older version of diskimage-builder. That's where that element is from.

this bug is still there in CentOS7 RDO Rocky.
I have commented out: disable-nouveau in Centos7 yaml file and it worked.