[2.4.0] juju-no-proxy variable is not applied due to legacy no-proxy value being auto-set by juju
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical Juju |
Fix Released
|
High
|
Joseph Phillips |
Bug Description
It appears to be that "auto noproxy" behavior triggers an incorrect behavior with new juju-no-proxy value albeit the legacy one is set to an empty string.
On 2.4.0 all juju-{http,
juju model-config -m controller logging-
juju model-config -m controller juju-http-proxy=http://
machine-0.log on the controller machine:
2018-07-17 20:27:14 DEBUG juju.worker.
2018-07-17 20:27:14 TRACE juju.worker.
# on a controller machine
ip -4 -o -br a s
lo UNKNOWN 127.0.0.1/8
enp1s0 UP 10.10.101.19/24
juju status -m controller
Model Controller Cloud/Region Version SLA Timestamp
controller vmaas vmaas 2.4.1 unsupported 23:44:37+03:00
Machine State DNS Inst id Series AZ Message
0 started 10.10.101.19 xwqr38 xenial default Deployed
snap info juju | grep -P ' candidate'
candidate: 2.4.1+2.4-7213ffe (4691) 63MB classic
update for 2.4.0 (non-candidate):
cat bootstrap-
juju-http-proxy: http://
juju-https-proxy: http://
juju-no-proxy: 'localhost,
logging-config: '<root>
juju bootstrap --config bootstrap-
root@maas-
2018-07-17 21:12:29 DEBUG juju.apiserver request_
2018-07-17 21:12:30 DEBUG juju.apiserver request_
2018-07-17 21:12:30 DEBUG juju.worker.logger logger.go:70 reconfiguring logging from "<root>=DEBUG" to "<root>
2018-07-17 21:12:34 DEBUG juju.worker.
2018-07-17 21:12:34 DEBUG juju.worker.
2018-07-17 21:12:34 DEBUG juju.worker.
2018-07-17 21:12:34 DEBUG juju.worker.
It appears to be that juju-http-proxy, juju-https-proxy and juju-no-proxy land into apt-http-proxy, apt-https-proxy and apt-no-proxy for some reason while they are not even set on the controller model:
juju model-config | grep proxy
apt-ftp-proxy default ""
apt-http-proxy default ""
apt-https-proxy default ""
apt-no-proxy default ""
ftp-proxy default ""
http-proxy default ""
https-proxy default ""
juju-ftp-proxy default ""
juju-http-proxy model http://
juju-https-proxy model http://
juju-no-proxy model localhost,
logging-config model <root>=
no-proxy default 127.0.0.
proxy-ssh default false
description: | updated |
summary: |
- juju-no-proxy variable is not applied due to legacy no-proxy value being - auto-set by juju + [2.4.0] juju-no-proxy variable is not applied due to legacy no-proxy + value being auto-set by juju |
description: | updated |
Changed in juju: | |
importance: | Undecided → High |
milestone: | none → 2.4.2 |
Changed in juju: | |
status: | New → Triaged |
assignee: | nobody → Joseph Phillips (manadart) |
Changed in juju: | |
status: | Triaged → Fix Committed |
Changed in juju: | |
status: | Fix Committed → Fix Released |
The actual problem in the juju code is apparent from changes in this PR: https:/ /github. com/juju/ juju/pull/ 8949
apt settings are populated because getWithFallback is used for them if they are not set which fetches values from JujuHTTPProxyKey and HTTPProxyKey, see: /github. com/juju/ juju/blob/ juju-2. 4.0/environs/ config/ config. go#L958- L960
https:/