widelands

"No Space" message in infrastructure.lua is not translated

Bug #1780486 reported by GunChleoc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Medium
Unassigned
widelands build20-rc1

Bug Description

The "No Space" message title, heading and body in data/scripting/infrastructure.lua appear in English to the user.

To reproduce, start a single player game on "Lake of Tranquility", choose red player, Empire, Fortified Village.

Related branches

lp://staging/~widelands-dev/widelands/bug_1780486_translation_fix
GunChleoc: Approve
Diff: 11 lines (+1/-0)
1 file modified
data/scripting/infrastructure.lua (+1/-0)
Revision history for this message
hessenfarmer (stephan-lutz) wrote :

this message doesn't appear in transifex to be translated

Revision history for this message
GunChleoc (gunchleoc) wrote :

Thanks for checking! We will need to select the correct textdomain and add a _ in front of the strings.

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

the _ is there however it is not listed in transifex

Revision history for this message
GunChleoc (gunchleoc) wrote :

No it isn't, because it's shorthand for a function:

"This Lua string is not translatable"
_"This Lua string is translatable"
_("This Lua string is also translatable")

Revision history for this message
GunChleoc (gunchleoc) wrote :

Duh, I didn't read your comment correctly. Ignore my last post.

An error with picking up the strings then I guess - will need to look at utils/buildcat.py

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

Forget my post. After looking into utils/buildcat.py I found the string on transifex. And it is correctly translated there. However it is located under widelands main where I diddn't expect it.

Revision history for this message
GunChleoc (gunchleoc) wrote :

Then it's a matter of assigning the correct Textdomain.

hessenfarmer (stephan-lutz)
Changed in widelands:
assignee: nobody → hessenfarmer (stephan-lutz)
status: New → In Progress
Revision history for this message
hessenfarmer (stephan-lutz) wrote :

ok branch with fix is uploaded. tested it. works.

GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
assignee: hessenfarmer (stephan-lutz) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.