kolla

The horizon container does not properly re-run maintenance tasks when configuration is modified

Bug #1778963 reported by Lars Kellogg-Stedman on 2018-06-27

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
kolla	Fix Released	Undecided	Unassigned	kolla 8.0.0 "Stein"
Rocky	Fix Released	Undecided	Unassigned
Stein	Fix Released	Undecided	Unassigned	kolla 8.0.0 "Stein"

Bug Description

The instructions for adding a new theme to Horizon are, briefly:

- Install the theme into /usr/share/openstack-dashboard/...
- Drop a configuration file into /etc/openstack-dashboard/local_settings.d

Unfortunately, the logic in extend_start.sh that determines whether or not to re-run the collectstatic/compress tasks does not take into account local_settings.d, and thus will not correctly activate these changes.

Tags:

Lars Kellogg-Stedman (larsks) on 2018-06-27

Changed in kolla:
status:	New → In Progress

Revision history for this message

Lars Kellogg-Stedman (larsks) wrote on 2018-06-27:

I've submitted a fix for this @ https://review.openstack.org/#/c/578498/

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-08-30: Fix merged to kolla (master)

Reviewed: https://review.openstack.org/578498
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=863f565b08867b87f3df7d1fc091ac26be90a1e8
Submitter: Zuul
Branch: master

commit 863f565b08867b87f3df7d1fc091ac26be90a1e8
Author: Lars Kellogg-Stedman <email address hidden>
Date: Wed Jun 27 13:34:26 2018 -0400

horizon: regenerate compressed javascript and css on configuration changes

    previously, the horizon container would not re-rerun the manage.py
    collectstatic/compress tasks when configuration files in
    /etc/openstack-dashboard/local-settings.d were modified (or added or
    deleted). This commit modifies the checksum calculation to take all
    configuration files into account.

Closes-bug: 1778963
Change-Id: I6946ab96cd758ef6eed56c9c4130046ac884b5e3

Changed in kolla:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-10-15: Fix proposed to kolla (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/610455

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-11-28: Fix merged to kolla (stable/rocky)

Reviewed: https://review.openstack.org/610455
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=5cd71cd7bb201a720067d1d850f94aade86f4b6f
Submitter: Zuul
Branch: stable/rocky

commit 5cd71cd7bb201a720067d1d850f94aade86f4b6f
Author: Lars Kellogg-Stedman <email address hidden>
Date: Wed Jun 27 13:34:26 2018 -0400

horizon: regenerate compressed javascript and css on configuration changes

    Closes-bug: 1778963
    Change-Id: I6946ab96cd758ef6eed56c9c4130046ac884b5e3
    (cherry picked from commit 863f565b08867b87f3df7d1fc091ac26be90a1e8)