Evergreen

Use builtin array_remove() function rather than our custom version

Bug #1778955 reported by Mike Rylander on 2018-06-27

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Evergreen	Fix Released	Low	Unassigned	Evergreen 3.7.1
3.2	Won't Fix	Undecided	Unassigned
3.3	Won't Fix	Undecided	Unassigned
3.4	Won't Fix	Undecided	Unassigned
3.5	Won't Fix	Undecided	Unassigned
3.6	Fix Released	Low	Unassigned	Evergreen 3.6.4

Bug Description

As of Postgres 9.3 there is a built in array_remove() function that is faster than our custom version that uses unnest(). We should use that instead. Branch forthcoming...

Tags:

Revision history for this message

Mike Rylander (mrylander) wrote on 2018-06-27:

Branch at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1778955-use-builtin-array_remove

tags:

added: pullrequest

Evergreen Bug Maintenance (bugmaster) on 2018-09-07

Changed in evergreen:
milestone:	3.2-beta → 3.2-rc

Evergreen Bug Maintenance (bugmaster) on 2018-10-01

Changed in evergreen:
milestone:	3.2-rc → 3.2.1

Evergreen Bug Maintenance (bugmaster) on 2018-10-24

Changed in evergreen:
milestone:	3.2.1 → 3.2.2

Evergreen Bug Maintenance (bugmaster) on 2018-11-26

Changed in evergreen:
milestone:	3.2.2 → 3.2.3

Evergreen Bug Maintenance (bugmaster) on 2019-01-21

Changed in evergreen:
milestone:	3.2.3 → 3.3-beta1

Evergreen Bug Maintenance (bugmaster) on 2019-03-01

Changed in evergreen:
milestone:	3.3-beta1 → 3.3-rc

Evergreen Bug Maintenance (bugmaster) on 2019-03-28

Changed in evergreen:
milestone:	3.3-rc → 3.3.1

Evergreen Bug Maintenance (bugmaster) on 2019-05-22

Changed in evergreen:
milestone:	3.3.1 → 3.3.2

Revision history for this message

Dan Pearl (dpearl) wrote on 2019-05-24:

This code is difficult to check by only its behavior (which should be identical to the old behavior), but while doing a desk check, I saw something unusual.

In The code that previously defined the evergreen.array_remove_item_by_value function, the name of the function has been changed to the built-in (perhaps the result of a global replace?). So the code now looks like

CREATE OR REPLACE FUNCTION array_remove(inp ANYARRAY, el ANYELEMENT)
RETURNS anyarray AS $$
SELECT ARRAY_AGG(x.e) FROM UNNEST( $1 ) x(e) WHERE x.e <> $2;

I'm not sure what Postgres does when you redefine a built-in, but my guess is that this code
should be removed. It certainly looks out of place.

Evergreen Bug Maintenance (bugmaster) on 2019-07-03

Changed in evergreen:
milestone:	3.3.2 → 3.3.3

Evergreen Bug Maintenance (bugmaster) on 2019-08-22

Changed in evergreen:
milestone:	3.3.3 → 3.3.4

Evergreen Bug Maintenance (bugmaster) on 2019-09-20

Changed in evergreen:
milestone:	3.3.4 → 3.3.5

Evergreen Bug Maintenance (bugmaster) on 2019-10-28

Changed in evergreen:
milestone:	3.3.5 → 3.4.2

Evergreen Bug Maintenance (bugmaster) on 2020-01-27

Changed in evergreen:
milestone:	3.4.2 → 3.4.3

Evergreen Bug Maintenance (bugmaster) on 2020-06-12

Changed in evergreen:
milestone:	3.4.3 → 3.4.4

Evergreen Bug Maintenance (bugmaster) on 2020-07-23

Changed in evergreen:
milestone:	3.4.4 → 3.3.8
milestone:	3.3.8 → 3.5.1

Revision history for this message

Jane Sandberg (sandbergja) wrote on 2020-08-06:

Thanks for this branch, Mike, and for catching that issue, Dan. I signed off at user/sandbergja/lp-1778955-use-builtin-array_remove

That branch also includes a commit to remove the issue that Dan found (it's a little odd that we were defining our custom function twice), as well as a little copy pasta that found its way into the upgrade script.

I also opted to uncomment the last line of your upgrade script, Mike, so that upgraded Evergreens aren't left with our custom function, in the hopes that removing it might reduce some confusion down the line.

It would be great to get this merged sooner rather than later, so nobody starts building new code off the old versions of these functions!

Evergreen Bug Maintenance (bugmaster) on 2020-08-12

Changed in evergreen:
milestone:	3.5.1 → 3.5.2

Terran McCanna (tmccanna) on 2020-10-20

Changed in evergreen:
milestone:	3.5.2 → 3.6.1

Terran McCanna (tmccanna) on 2020-10-20

tags:

added: deprecation

Terran McCanna (tmccanna) on 2020-10-21

tags:

added: cleanup performance

Evergreen Bug Maintenance (bugmaster) on 2020-11-27

Changed in evergreen:
milestone:	3.6.1 → 3.6.2

Evergreen Bug Maintenance (bugmaster) on 2021-02-18

Changed in evergreen:
milestone:	3.6.2 → 3.6.3

Revision history for this message

Rogan Hamby (rogan-hamby) wrote on 2021-03-18:

I thought I had tested and signed off on this so I will do so today (assuming testing goes well).

Changed in evergreen:
assignee:	nobody → Rogan Hamby (rogan-hamby)

Revision history for this message

Rogan Hamby (rogan-hamby) wrote on 2021-03-18:

sign off pushed to user/rogan/lp1778955_use_native_array_remove

Changed in evergreen:
assignee:	Rogan Hamby (rogan-hamby) → nobody
tags:	added: signedup
tags:	added: signedoff removed: signedup

Evergreen Bug Maintenance (bugmaster) on 2021-04-01

Changed in evergreen:
milestone:	3.6.3 → 3.6.4

Revision history for this message

Galen Charlton (gmc) wrote on 2021-06-02:

Pushed down to rel_3_6. Thanks, Mike, Dan, Jane, and Rogan!

Changed in evergreen:
milestone:	3.6.4 → 3.7.1
status:	New → Confirmed
importance:	Undecided → Low
status:	Confirmed → Fix Committed

Evergreen Bug Maintenance (bugmaster) on 2021-06-25

Changed in evergreen:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.