MAAS

[UI] MAAS Configuration | Name allows for unescaped quote

Bug #1775099 reported by Kit Randel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Critical
Kit Randel
MAAS 2.5.0alpha1
2.4
Fix Released
Critical
Unassigned
MAAS 2.4.1

Bug Description

Single quotes don't appear to be escaped when saved in Settings | General | MAAS Configuration | MAAS name.

This appears to generate an error on the /dashboard route.

```
Error: [$parse:lexerr] Lexer Error: Unterminated quote at columns 18-19 ['] in expression [site = 'kit's maas'].
http://errors.angularjs.org/1.5.10/$parse/lexerr?p0=Unterminated%20quote&p1=s%2018-19%20%5B'%5D&p2=site%20%3D%20'kit's%20maas'
    at http://192.168.64.7:5240/MAAS/combo/angular.js?v=2.3.0fromsource(git+d70d470f89afc5d7c8355177b7a20172c43e3d87):2:757
    at Lexer.throwError (http://192.168.64.7:5240/MAAS/combo/angular.js?v=2.3.0fromsource(git+d70d470f89afc5d7c8355177b7a20172c43e3d87):6:29355)
    at Lexer.readString (http://192.168.64.7:5240/MAAS/combo/angular.js?v=2.3.0fromsource(git+d70d470f89afc5d7c8355177b7a20172c43e3d87):6:31032)
    at Lexer.lex (http://192.168.64.7:5240/MAAS/combo/angular.js?v=2.3.0fromsource(git+d70d470f89afc5d7c8355177b7a20172c43e3d87):6:27249)
    at AST.ast (http://192.168.64.7:5240/MAAS/combo/angular.js?v=2.3.0fromsource(git+d70d470f89afc5d7c8355177b7a20172c43e3d87):6:31850)
    at ASTCompiler.compile (http://192.168.64.7:5240/MAAS/combo/angular.js?v=2.3.0fromsource(git+d70d470f89afc5d7c8355177b7a20172c43e3d87):7:10366)
    at Parser.parse (http://192.168.64.7:5240/MAAS/combo/angular.js?v=2.3.0fromsource(git+d70d470f89afc5d7c8355177b7a20172c43e3d87):8:851)
    at $parse (http://192.168.64.7:5240/MAAS/combo/angular.js?v=2.3.0fromsource(git+d70d470f89afc5d7c8355177b7a20172c43e3d87):8:2641)
    at Scope.$eval (http://192.168.64.7:5240/MAAS/combo/angular.js?v=2.3.0fromsource(git+d70d470f89afc5d7c8355177b7a20172c43e3d87):8:21764)
    at Object.pre (http://192.168.64.7:5240/MAAS/combo/angular.js?v=2.3.0fromsource(git+d70d470f89afc5d7c8355177b7a20172c43e3d87):10:17767) <body class="has-sticky-footer" data-ng-init="site = 'kit's maas'" data-maas-version-reloader="" window-width="">
```

Tags: ui

Related branches

~andreserl/maas:lp1773387_lp1775099_2.4
Andres Rodriguez (community): Approve
Diff: 79 lines (+26/-26)
2 files modified
src/maasserver/static/partials/pod-details.html (+25/-25)
src/maasserver/templates/maasserver/index.html (+1/-1)
~blr/maas:escape-sitename-lp1775099
Blake Rouse (community): Approve
MAAS Lander: Approve
Diff: 13 lines (+1/-1)
1 file modified
src/maasserver/templates/maasserver/index.html (+1/-1)
Andres Rodriguez (andreserl)
Changed in maas:
importance: Undecided → Critical
status: New → Triaged
milestone: none → 2.5.0
Kit Randel (blr)
summary: - MAAS Configuration | Name allows for unescaped quote [UI]
+ [UI] MAAS Configuration | Name allows for unescaped quote
Andres Rodriguez (andreserl)
Changed in maas:
status: Triaged → In Progress
assignee: nobody → Kit Randel (blr)
MAAS Lander (maas-lander)
Changed in maas:
status: In Progress → Fix Committed
Andres Rodriguez (andreserl)
Changed in maas:
milestone: 2.5.0 → 2.5.0alpha1
Andres Rodriguez (andreserl)
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.